Reviewed: https://review.openstack.org/453840 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5a9cc2fb7af3e3a9db44646bbd23cfcfb16891f5 Submitter: Jenkins Branch: master
commit 5a9cc2fb7af3e3a9db44646bbd23cfcfb16891f5 Author: Matt Riedemann <[email protected]> Date: Wed Apr 5 15:12:41 2017 -0400 Short-circuit local delete path for cells v2 and InstanceNotFound When we're going down the local delete path for cells v2 in the API and instance.destroy() fails with an InstanceNotFound error, we are racing with a concurrent delete request and know that the instance is alread deleted, so we can just return rather than fall through to the rest of the code in the _delete() method, like for BDMs and console tokens. Change-Id: I58690a25044d2804573451983323dde05be9e5d6 Closes-Bug: #1680211 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1680211 Title: InstanceNotFound during local delete in API does not short-circuit Status in OpenStack Compute (nova): Fix Released Status in OpenStack Compute (nova) ocata series: New Bug description: The cells v2-specific local delete path in the compute API is handling an InstanceNotFound when instance.destroy() fails, but doesn't return from the _delete() method: https://github.com/openstack/nova/blob/caee532ff82d618fb30ace84a4cd0d7b1d1faa96/nova/compute/api.py#L1889 It just continues to the rest of the delete code, which is pointless since we already know the instance is gone. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1680211/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
