Public bug reported: This unit test:
https://github.com/openstack/nova/blob/6103ec7c113121866344cdca2fbbbf7b80dfa975/nova/tests/unit/db/test_db_api.py#L1170 Is not actually testing the thing it's supposed to be testing, which is: https://github.com/openstack/nova/blob/6103ec7c113121866344cdca2fbbbf7b80dfa975/nova/db/sqlalchemy/api.py#L2528 It's basically testing the same method that's tested right after it: https://github.com/openstack/nova/blob/6103ec7c113121866344cdca2fbbbf7b80dfa975/nova/tests/unit/db/test_db_api.py#L1186 ** Affects: nova Importance: Medium Assignee: Matt Riedemann (mriedem) Status: In Progress ** Tags: db testing -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1680614 Title: test_instance_get_all_by_host does not actually test instance_get_all_by_host Status in OpenStack Compute (nova): In Progress Bug description: This unit test: https://github.com/openstack/nova/blob/6103ec7c113121866344cdca2fbbbf7b80dfa975/nova/tests/unit/db/test_db_api.py#L1170 Is not actually testing the thing it's supposed to be testing, which is: https://github.com/openstack/nova/blob/6103ec7c113121866344cdca2fbbbf7b80dfa975/nova/db/sqlalchemy/api.py#L2528 It's basically testing the same method that's tested right after it: https://github.com/openstack/nova/blob/6103ec7c113121866344cdca2fbbbf7b80dfa975/nova/tests/unit/db/test_db_api.py#L1186 To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1680614/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp

