Reviewed: https://review.openstack.org/454368 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d52bcc616f2d1c0df7bad8a6f5a00adc7ad1fb27 Submitter: Jenkins Branch: master
commit d52bcc616f2d1c0df7bad8a6f5a00adc7ad1fb27 Author: Matt Riedemann <[email protected]> Date: Thu Apr 6 17:59:34 2017 -0400 Fix joins in instance_get_all_by_host Some callers of instance_get_all_by_host are passing in columns_to_join=[], like the _sync_scheduler_instance_info periodic task in the compute manager, to avoid unnecessary joins with other tables. The problem was columns_to_join wasn't being passed through to _instance_get_all_query which builds the actual query method, and defaults to join on info_cache and security_groups. This fixes the problem by passing through columns_to_join and provides tests to show it working both with and without the joins. Change-Id: I69f2ddca8fb0935e03b0f426891d01360940a85a Closes-Bug: #1680616 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1680616 Title: instance_get_all_by_host joins tables even if told not to Status in OpenStack Compute (nova): Fix Released Bug description: The instance_get_all_by_host DB API will join the info_cache and security_groups tables even if told not to by passing in columns_to_join=[], which the _sync_instance_scheduler_info periodic task from the compute manager does. That is because instance_get_all_by_host doesn't pass columns_to_join through to _instance_get_all_query which will default to join on info_cache and security_groups: https://github.com/openstack/nova/blob/6103ec7c113121866344cdca2fbbbf7b80dfa975/nova/db/sqlalchemy/api.py#L2530 https://github.com/openstack/nova/blob/6103ec7c113121866344cdca2fbbbf7b80dfa975/nova/db/sqlalchemy/api.py#L2513 To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1680616/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
