Reviewed: https://review.openstack.org/460171 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=02559e544e29c88497cb8579a4ceed06c0adf91d Submitter: Jenkins Branch: master
commit 02559e544e29c88497cb8579a4ceed06c0adf91d Author: wei.ying <[email protected]> Date: Wed Apr 26 23:07:37 2017 +0800 Fix the legacy experience launch instance dialog can not open Since the commit c219a3efc6622c6e5857577d94633efc7d139860 removed js file 'horizon.instances.js' in the template file ' _scripts.html', If enable the legacy experience launch instance (Set 'LAUNCH_INSTANCE_LEGACY_ENABLED = True' and 'LAUNCH_INSTANCE_NG_ENABLED = False' in the local_settings.py) and click launch instance, we can not open launch instance dialog and also see the following in console.log. VM22778:3 Uncaught TypeError: Cannot read property 'workflow_init' of undefined Change-Id: Ia9e22df5129527e4b021599bbdec9a668a04ee4b Closes-Bug: #1686431 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1686431 Title: Fix script error in django create instance form. Status in OpenStack Dashboard (Horizon): Fix Released Bug description: Env: devstack master branch Reason: not load horizon.instances.js in _scripts.html Steps to reproduce: 1.Enable 'LAUNCH_INSTANCE_LEGACY_ENABLED = True' and 'LAUNCH_INSTANCE_NG_ENABLED = False' in openstack_dashboard/local/local_settings.py L:244 & L:245 2. Go to Project/Compute/Instances panel 3. Click Launch Instance button, we'll see the following in console.log JS error info: VM22778:3 Uncaught TypeError: Cannot read property 'workflow_init' of undefined at eval (eval at <anonymous> (732ce617825a.js:48), <anonymous>:3:22) at eval (<anonymous>) at 732ce617825a.js:48 at Function.globalEval (732ce617825a.js:48) at jQuery.fn.init.domManip (732ce617825a.js:412) at jQuery.fn.init.append (732ce617825a.js:396) at Object.horizon.modals.success (1fb30c7e6805.js:67) at Object.success (1fb30c7e6805.js:84) at fire (732ce617825a.js:208) at Object.fireWith [as resolveWith] (732ce617825a.js:213) To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1686431/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp

