Reviewed: https://review.openstack.org/458958 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=746e48efa32fd599817197ffd7ad434a35f96165 Submitter: Jenkins Branch: master
commit 746e48efa32fd599817197ffd7ad434a35f96165 Author: Matt Riedemann <[email protected]> Date: Thu Apr 27 14:44:52 2017 -0400 Do not log live migration success when it actually failed During post live migration, if post live migration on destination fails, then we log a stacktrace but continue to perform cleanup on the source side. However, at the end of the _post_live_migration method it was logging that things were successful on the destination host, which they weren't, which is really confusing when you're trying to debug the failure and seeing this conflict in the logs. This patch simply sets a flag if we failed post live migration at the destination host so we don't log the success message later on the source host, plus tests to show the flag is set and checked. Change-Id: I16e70912a13c963031397e66a8553b2c199d50bd Closes-Bug: #1685340 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1685340 Title: compute logs tell me live migration finished successfully when it actually failed Status in OpenStack Compute (nova): Fix Released Status in OpenStack Compute (nova) newton series: New Status in OpenStack Compute (nova) ocata series: New Bug description: This tells me post live migration at destination failed: http://logs.openstack.org/43/458843/1/check/gate-tempest-dsvm- multinode-live-migration-ubuntu- xenial/697a501/logs/subnode-2/screen-n-cpu.txt.gz#_2017-04-21_13_54_10_281 2017-04-21 13:54:10.281 10362 ERROR nova.compute.manager [req- 7ecbf938-9e55-4e4c-b7da-63eef0f8d4a9 tempest- LiveBlockMigrationTestJSON-208732686 tempest- LiveBlockMigrationTestJSON-208732686] [instance: 9bf9f268-5242-4b1d- 8fe6-ee348b2b8d3e] Post live migration at destination ubuntu-xenial-2 -node-osic-cloud1-s3500-8527282 failed Later on, the logs tell me it was successful: http://logs.openstack.org/43/458843/1/check/gate-tempest-dsvm- multinode-live-migration-ubuntu- xenial/697a501/logs/subnode-2/screen-n-cpu.txt.gz#_2017-04-21_13_54_11_080 2017-04-21 13:54:11.080 10362 INFO nova.compute.manager [req- 7ecbf938-9e55-4e4c-b7da-63eef0f8d4a9 tempest- LiveBlockMigrationTestJSON-208732686 tempest- LiveBlockMigrationTestJSON-208732686] [instance: 9bf9f268-5242-4b1d- 8fe6-ee348b2b8d3e] Migrating instance to ubuntu-xenial-2-node-osic- cloud1-s3500-8527282 finished successfully. That's because we don't stop on the failure because we want to continue with cleanup, but we don't check if we failed when emitting the success message. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1685340/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
