Reviewed: https://review.openstack.org/462013 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b971ac799f632e1f2652adb2191c76fc29f271dc Submitter: Jenkins Branch: master
commit b971ac799f632e1f2652adb2191c76fc29f271dc Author: Dongcan Ye <[email protected]> Date: Wed May 3 15:07:36 2017 +0800 Add tempest test for l3-ha extension Add missing l3-ha extension under neutron tempest tests. Change-Id: Ia608d3f5d63a88eefa4e61da6df2f3656c8446a0 Closes-Bug: #1684065 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1684065 Title: No tests available for l3-ha extension under neutron tempest tests Status in neutron: Fix Released Bug description: After doing a grep on neutron test repo for the extension I am not able to find any tests that are related to this extension. I believe coverage should be increased in this case. I am adding below snippet of the discussion I had with Ihar regarding this. """ Indeed it seems there are no tests that explicitly target the extension (meaning, they don't utilize the 'ha' attribute added by https://github.com/openstack/neutron/blob/master/neutron/extensions/l3_ext_ha_mode.py#L23) That doesn't mean that there are no tests that cover the implementation. Instead, existing tests utilizing neutron routers will use keepalived implementation if neutron.conf is configured to use HA routers for router creation: https://github.com/openstack/neutron/blob/master/neutron/db/l3_hamode_db.py#L62 I agree that it's not ideal, and we should have some tests that actually check that 'ha' attribute works as expected. You may want to report a bug for that matter in upstream Launchpad if you feel like. """ Please let me know if more information is needed from my end. To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1684065/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
