Reviewed: https://review.openstack.org/461205 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b0a5f30248ac905f676f9ad77f1632430a3acc2e Submitter: Jenkins Branch: master
commit b0a5f30248ac905f676f9ad77f1632430a3acc2e Author: Akihiro Motoki <[email protected]> Date: Sat Apr 29 11:26:45 2017 +0000 Testing: mock add_panel_mocks() more flexible Tis commit enhances openstack_dashboard.test.helpers.TestCase .add_panel_mocks() method to more flexible way. Now the mock definitions are defined in the test settings and setUp() in unit tests and selenium tests sets up mocks defined in the test settings TEST_GLOBAL_MOCKS_ON_PANELS. This is a preparation for drop of deprecated options (enable_firewall and enable_vpn). They were marked as deprecated long ago, but they are still kept just because we need a lot of changes in unit tests if dropped. By this change, we no longer need to use settings just for testing. enable_firewall/enable_vpn=False are dropped (default is True) to confirm this change works well. Related-Bug: #1687185 Change-Id: I0a5ebcf8d75e704420d3a5af46fde268a59aa9ec ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1687185 Title: Drop deprecated enable_firewall and enable_vpn settings Status in OpenStack Dashboard (Horizon): Fix Released Bug description: enable_firewall and enable_vpn settings in OPENSTACK_NEUTRON_NETWORK were marked as deprecated in Juno release, but they still live in horizon. We now have more consistent way "Pluggable panel" to enable/disable panels and these settings are unnecessary. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1687185/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
