Reviewed: https://review.openstack.org/464765 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=03cb9c04f071a19fe4fd8f106cfd7e65e2045639 Submitter: Jenkins Branch: master
commit 03cb9c04f071a19fe4fd8f106cfd7e65e2045639 Author: Matt Riedemann <[email protected]> Date: Mon May 15 18:15:55 2017 -0400 libvirt: expand checks for SubclassSignatureTestCase Change I01c908add1312063f0db724110f7e5927ff281ff introduced tests to ensure that the libvirt volume drivers would have the same method signature as their parent classes, but only tested certain filesystem-style volume drivers. Because of that, change Iafb9ce4c1582715c6afac87cc9ae62e259f21b07 did not fail the tests but failed to have the correct signature for connect_volume and disconnect_volume. This change expands the tests to use the base libvirt volume driver rather than just the FS-style one so it will catch things like the new LibvirtHyperScaleVolumeDriver. Change-Id: Ibf30dbc732eb2b2755e89dece330fe9c4913dbde Closes-Bug: #1690932 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1690932 Title: SubclassSignatureTestCase isn't being used properly in libvirt volume tests Status in OpenStack Compute (nova): Fix Released Bug description: SubclassSignatureTestCase isn't being used properly in the libvirt volume driver tests. It's only being used to test the drivers that extend LibvirtBaseFileSystemVolumeDriver which is not everything. It should really be used against the LibvirtBaseVolumeDriver class. For example, the new veritas hyperscale driver didn't fail the check once it was rebased to pick up this test: https://review.openstack.org/#/c/443951/14/nova/virt/libvirt/volume/vrtshyperscale.py To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1690932/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
