Reviewed: https://review.openstack.org/441204 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=563c0927d14d052e3f1fad80df95fe4a7c48d38b Submitter: Jenkins Branch: master
commit 563c0927d14d052e3f1fad80df95fe4a7c48d38b Author: Matt Riedemann <[email protected]> Date: Tue Jun 6 14:08:37 2017 -0400 libvirt: Check if domain is persistent before detaching devices Previously the libvirt driver would always assume that it was only detaching devices (volumes or virtual interfaces) from a persistent domain however that is not always the case. For example when rolling back from a live migration an attempt is made to detach volumes from the transient destination domain that is being cleaned up. This attempt would fail with the previous assumption of the domain being persistent in place. This change introduces a simple call to has_persistent_configuration within detach_device_with_retry to confirm the state of the domain before attempting to detach. Closes-Bug: #1669857 Closes-Bug: #1696125 Change-Id: I95948721a0119f5f54dbe50d4455fd47d422164b ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1669857 Title: libvirt.VIR_DOMAIN_AFFECT_CONFIG provided when detaching volumes during LM rollback Status in OpenStack Compute (nova): Fix Released Bug description: Description =========== During a live-migration rollback the libvirt driver will attempt to detach volumes from the transient destination domain while providing the libvirt.VIR_DOMAIN_AFFECT_CONFIG flag. This will always fail as the domain is not persistent. Steps to reproduce ================== - live-migrate an instance with volumes attached. - force a rollback of the live-migration resulting in volumes being detached from the destination domain. Expected result =============== libvirt.VIR_DOMAIN_AFFECT_CONFIG flag not provided while attempting to detach a volume from the transient destination domain. Actual result ============= libvirt.VIR_DOMAIN_AFFECT_CONFIG flag provided while attempting to detach a volume from the transient destination domain, resulting in a failure during the live-migration rollback. Environment =========== 1. Exact version of OpenStack you are running. See the following list for all releases: http://docs.openstack.org/releases/ master 2. Which hypervisor did you use? (For example: Libvirt + KVM, Libvirt + XEN, Hyper-V, PowerKVM, ...) What's the version of that? libvirt 2. Which storage type did you use? (For example: Ceph, LVM, GPFS, ...) What's the version of that? n/a 3. Which networking type did you use? (For example: nova-network, Neutron with OpenVSwitch, ...) n/a Logs & Configs ============== Rollback of failed live migration with attached volume fails on destination https://bugzilla.redhat.com/show_bug.cgi?id=1424481 To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1669857/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
