Reviewed: https://review.openstack.org/430362
Committed:
https://git.openstack.org/cgit/openstack/python-troveclient/commit/?id=ccceffa7f56bfcc2ff42f98a6272ace866993d09
Submitter: Jenkins
Branch: master
commit ccceffa7f56bfcc2ff42f98a6272ace866993d09
Author: Gábor Antal <an...@inf.u-szeged.hu>
Date: Tue Feb 7 17:54:11 2017 +0100
Handle log message interpolation by the logger
According to OpenStack Guideline[1], logged string message should be
interpolated by the logger.
Also, upgraded hacking requirement, to enable H904 check.
[1]:
http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages
Co-Authored-By: jiansong <jian.s...@easystack.cn>
Change-Id: I3f020b6bcb1b9bf6d18a3b4f738c13cccd1bbff8
Closes-Bug: #1596829
** Changed in: python-troveclient
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1596829
Title:
String interpolation should be delayed at logging calls
Status in congress:
Fix Released
Status in Glance:
In Progress
Status in glance_store:
In Progress
Status in OpenStack Dashboard (Horizon):
Fix Released
Status in Ironic:
Fix Released
Status in masakari:
Fix Released
Status in networking-vsphere:
Fix Released
Status in OpenStack Compute (nova):
Fix Released
Status in os-brick:
Fix Released
Status in os-vif:
Fix Released
Status in python-cinderclient:
Fix Released
Status in Glance Client:
Fix Released
Status in python-manilaclient:
Fix Released
Status in python-openstackclient:
Fix Released
Status in python-troveclient:
Fix Released
Status in senlin:
Invalid
Bug description:
String interpolation should be delayed to be handled by the logging
code, rather than being done at the point of the logging call.
Wrong: LOG.debug('Example: %s' % 'bad')
Right: LOG.debug('Example: %s', 'good')
See the following guideline.
* http://docs.openstack.org/developer/oslo.i18n/guidelines.html
#adding-variables-to-log-messages
The rule for it should be added to hacking checks.
To manage notifications about this bug go to:
https://bugs.launchpad.net/congress/+bug/1596829/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
