Reviewed: https://review.openstack.org/465659 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=5ae41997c4e9f7b94cabebd243b4afaf52ea446a Submitter: Jenkins Branch: master
commit 5ae41997c4e9f7b94cabebd243b4afaf52ea446a Author: Beth Elwell <[email protected]> Date: Wed May 17 17:06:40 2017 +0100 Add ability to choose flavor in dashboard if value "0" Adds the ability to choose flavor smaller than that of the glance.min_disk if the value is "0". The "0" case is a special case which uses the native base image size as the size of the ephemeral root volume. Change-Id: I2ed98a2a07fd075b1ea6362d8955911604286d7c Closes-Bug: #1677206 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1677206 Title: Can not choose flavor in dashboard if glance.min_disk > flavor.disk Status in OpenStack Dashboard (Horizon): Fix Released Bug description: Description of problem: Can not choose flavor in dashboard if glance.min_disk > flavor.disk Version-Release number of selected component (if applicable): python-django-horizon-8.0.1-6.el7ost.noarch How reproducible: 100% Steps to Reproduce: 1. Create a flavor with Root Disk (GB) = 0 2. Create an image with Minimum Disk (GB) = 1 3. Launch instance and select the image we created in step2. 4. We can not select the flavor we created in step 1 and it is showing grey. Actual results: Horizon is making an unnecessary check. https://github.com/openstack/horizon/blob/stable/liberty/horizon/static/horizon/js/horizon.quota.js#L150 https://github.com/openstack/horizon/blob/stable/liberty/horizon/static/horizon/js/horizon.quota.js#L86 https://github.com/openstack/horizon/blob/stable/liberty/horizon/static/horizon/js/horizon.quota.js#L78 Expected results: We should be able to launch instance even though glance.min_disk > flavor.disk. Additional info: There is no problem if we launch instance from command line. In /usr/lib/python2.7/site-packages/nova/compute/api.py 736 # NOTE(johannes): root_gb is allowed to be 0 for legacy reasons 737 # since libvirt interpreted the value differently than other 738 # drivers. A value of 0 means don't check size. 744 if image_min_disk > dest_size: 745 raise exception.FlavorDiskSmallerThanMinDisk( 746 flavor_size=dest_size, image_min_disk=image_min_disk) We can see that if the root_gb is 0, then nova will not check the disk size. But Horizon seems to be still checking even though the root_gb is 0. Horizon should take care of this situation when root_gb == 0. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1677206/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
