Reviewed: https://review.openstack.org/470798 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a7c054c55153c44891b8d1b14f93f0e03777fa6c Submitter: Jenkins Branch: master
commit a7c054c55153c44891b8d1b14f93f0e03777fa6c Author: jianghua wang <[email protected]> Date: Mon Jun 5 03:02:09 2017 +0100 Fix the race condition with novnc The first RFP negotiation message potentially arrived earlier, in which case the message will be swallowed by the recv() which receive response for the http request. This commit is to ensure only the response is removed from the socket buffer, so it won't impact the following RFP negotiation. Change-Id: I100e140acbc2d981f7b98e12b3e9ae02844f41fd Closes-Bug: #1695844 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1695844 Title: test_novnc failed with socket recv time Status in OpenStack Compute (nova): Fix Released Bug description: We observed race condition with novnc test. Failed rate is about 1/10. http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/72/463672/3/check/dsvm-tempest-neutron-network/849c338/run_tests.log ============================== Failed 1 tests - output below: ============================== tempest.api.compute.servers.test_novnc.NoVNCConsoleTestJSON.test_novnc[id-c640fdff-8ab4-45a4-a5d8-7e6146cbd0dc] --------------------------------------------------------------------------------------------------------------- Captured traceback: ~~~~~~~~~~~~~~~~~~~ Traceback (most recent call last): File "tempest/api/compute/servers/test_novnc.py", line 172, in test_novnc self._validate_rfb_negotiation() File "tempest/api/compute/servers/test_novnc.py", line 84, in _validate_rfb_negotiation data = self._websocket.receive_frame() File "tempest/common/compute.py", line 282, in receive_frame header = self._recv(2) File "tempest/common/compute.py", line 273, in _recv data_from_socket = self._socket.recv(recv_size) File "/opt/stack/new/tempest/.tox/tempest/local/lib/python2.7/site-packages/fixtures/_fixtures/timeout.py", line 52, in signal_handler raise TimeoutException() fixtures._fixtures.timeout.TimeoutException To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1695844/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
