Found open reviews for this bug in gerrit, setting to In Progress. review: https://review.openstack.org/396130 in branch: master
** Changed in: nova Status: Invalid => In Progress ** Changed in: nova Assignee: (unassigned) => Stephen Finucane (stephenfinucane) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1466451 Title: Nova should verify that devname in pci_passthrough_whitelist is not empty Status in OpenStack Compute (nova): In Progress Bug description: According to https://wiki.openstack.org/wiki/SR-IOV-Passthrough-For-Networking: "The devname can be a valid PCI device name. The only device names that are supported are those displayed by the Linux utility ifconfig -a and correspond to either a PF or a VF on a vNIC" However it's possible to supply an empty string as devname e.g. pci_passthrough_whitelist = {"devname": "", "physical_network":"physnet2"} It's also possible to have an entry: pci_passthrough_whitelist = {"physical_network":"physnet2"} which shouldn't be valid. Nova should verify that devname is not an empty string and that devname,address or product_id/vendor_id are supplied. Version ====== python-nova-2015.1.0-4.el7ost.noarch Expected result ============= Nova compute should fail to start when specifying an empty string for devname when using physical_network or when not specifying devname,address or product_id/vendor_id To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1466451/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp