Reviewed: https://review.openstack.org/486096 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0e68f860c22c139c75170d32ca4f196c0cc696be Submitter: Jenkins Branch: master
commit 0e68f860c22c139c75170d32ca4f196c0cc696be Author: Sean McGinnis <[email protected]> Date: Fri Jul 21 05:28:12 2017 -0500 Don't cast cinderclient microversions to float Current python-cinderclient release has a MAX_VERSION of 3.40. This test mocks the result from getting the max server and client version to be whatever is MAX_VERSION, but it was casting it to a float, resulting in the max being evaluated at 3.4. float() can be removed so requests for versions greater than 3.4 can pass. Change-Id: I399e2bd7763bc2240752aaa22dea8ff4ee580ab8 Closes-bug: #1705681 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1705681 Title: Cinder client tests cast microversion to a float causing mismatch Status in OpenStack Compute (nova): Fix Released Bug description: In nova/tests/unit/volume/test_cinder.py, test_create_v3_client_with_microversion_available mocks out the return value for cinderclient.client.get_highest_client_server_version to be whatever the python-cinderclient MAX_VERSION is. The problem is, it is casting this as a float(), so for microversions on the 10's boundary (3.10, 3.20, etc.) this ends up losing the last digit (3.1, 3.2, etc.). The current release puts the Cinder MAX_VERSION at 3.40, causing this test to fail when requesting the specific version. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1705681/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
