Reviewed: https://review.openstack.org/493963 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=7c463e2e761ae545bdc86576c2bba537c8cfc27e Submitter: Jenkins Branch: master
commit 7c463e2e761ae545bdc86576c2bba537c8cfc27e Author: Chris Dent <[email protected]> Date: Tue Aug 15 18:32:17 2017 +0100 Make scheduler.utils.merge_resources ignore zero values If merge_resources results in a class of resource with a value of zero, and that result is then used to form an allocation request, the allocation will be rejected: the json schema for allocations requires the value of a resource class to be at least 1. Therefore merge_resources is changed so that anywhere the value is zero in the results, that key is popped from the dict. We need to do it in this way because we are modifying an existing dict, not returning a new one that we are assembling. Change-Id: Idea9315d6bce8b341f0c3d2dc0accca6ac259587 Closes-Bug: #1710908 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1710908 Title: scheduler.utils.merge_resources allows zero value resources Status in OpenStack Compute (nova): Fix Released Bug description: (master as of 2017-08-15) If the merge of two resources of the same class can result in a sum of zero, or one of the provided keys has a value of zero in the first place and it is only in one of the provided resource dicts, the result dict of resources will have a zero value entry. If this is then used directly to produce an allocations entry, the allocation will fail. I discovered this while manually testing resizes of servers using flavors with no disk. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1710908/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
