Reviewed: https://review.openstack.org/495512 Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=d3871a57b895902432bc7ddb98f9bb757cc2502b Submitter: Jenkins Branch: master
commit d3871a57b895902432bc7ddb98f9bb757cc2502b Author: Brian Rosmaita <[email protected]> Date: Sat Aug 19 13:00:20 2017 -0400 Fix Image API 'versions' response Whether or not the v2.6 EXPERIMENTAL API is exposed at a site depends on the enable_image_import config value. If it's False (the default), then the API a client sees is the CURRENT v2.5 API, and any of the v2.6 calls made against 2.5 return a 404 (same as if you were running Ocata). This patch adjusts the 'versions' response so that when enable_image_import=False, the EXPERIMENTAL v2.6 does not appear in the response. Change-Id: Ibe164f02c99d10f5a5edd0de96c665413a12f700 Closes-bug: #1711829 ** Changed in: glance Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to Glance. https://bugs.launchpad.net/bugs/1711829 Title: Pike 'versions' response includes 2.6 even when image import is not enabled Status in Glance: Fix Released Bug description: The bug is that the 'versions' response shows the EXPERIMENTAL 2.6 version even when enable_image_import=False. This is why it's a bug. There are a series of changes [0] in RC-2 to make sure that when image import is not enabled, the /v2 responses to v2.6 calls are the same as what you'd see in v2.5, that is, 404 for: /v2/images/{image_id}/stage /v2/images/{image_id}/import /v2/info/import and the OpenStack-image-import-methods header is not included on POST /v2/images . That being the case, we should not advertise the availability of 2.6 for a Glance in the default configuration (that is, configured with enable_image_import=False). The calls won't 500 or anything, but showing 2.6 as available will confuse consumers (and possibly deployers testing their API nodes). [0] These patches: https://review.openstack.org/#/c/491249/ https://review.openstack.org/#/c/494544/ https://review.openstack.org/#/c/494036/ To manage notifications about this bug go to: https://bugs.launchpad.net/glance/+bug/1711829/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
