Reviewed: https://review.openstack.org/501400 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=943be8560dd9410de6b0f507d9dbc85df0c1d928 Submitter: Jenkins Branch: master
commit 943be8560dd9410de6b0f507d9dbc85df0c1d928 Author: Matt Riedemann <[email protected]> Date: Wed Sep 6 15:52:51 2017 -0400 Fix test_rpc_consumer_isolation for oslo.messaging 5.31.0 With this change in oslo.messaging 5.31.0: I0bbf9fca0ecbe71efa87c9613ffd32eb718f2c0e The endpoint passed in is going to be checked for a 'target' attribute and check it's type if set, so looking for it has to be ignored. There are also some services tests that are mocking out what is eventually an rpc endpoint and those need to specifically set the target attribute to None otherwise .get() on the Mock will return another Mock and cause a failure. Change-Id: Ic12df8b12b1379f902137d49b605daaf0b89801d Closes-Bug: #1715470 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1715470 Title: test_rpc_consumer_isolation fails with oslo.messaging 5.31.0 Status in Cinder: Fix Released Status in OpenStack Compute (nova): Fix Released Bug description: Seen in this upper-constraints change: http://logs.openstack.org/70/500770/9/check/gate-cross-cinder-python27 -ubuntu-xenial/1b40c85/console.html#_2017-09-06_18_33_51_290254 2017-09-06 18:33:51.290254 | cinder.tests.unit.test_test.IsolationTestCase.test_rpc_consumer_isolation 2017-09-06 18:33:51.290274 | ------------------------------------------------------------------------- 2017-09-06 18:33:51.290280 | 2017-09-06 18:33:51.290289 | Captured traceback: 2017-09-06 18:33:51.290298 | ~~~~~~~~~~~~~~~~~~~ 2017-09-06 18:33:51.290311 | Traceback (most recent call last): 2017-09-06 18:33:51.290334 | File "cinder/tests/unit/test_test.py", line 46, in test_rpc_consumer_isolation 2017-09-06 18:33:51.290348 | endpoints=[NeverCalled()]) 2017-09-06 18:33:51.290364 | File "cinder/rpc.py", line 159, in get_server 2017-09-06 18:33:51.290377 | access_policy=access_policy) 2017-09-06 18:33:51.290418 | File "/home/jenkins/workspace/gate-cross-cinder-python27-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/debtcollector/updating.py", line 64, in wrapper 2017-09-06 18:33:51.290433 | return wrapped(*args, **kwargs) 2017-09-06 18:33:51.290475 | File "/home/jenkins/workspace/gate-cross-cinder-python27-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/oslo_messaging/rpc/server.py", line 214, in get_rpc_server 2017-09-06 18:33:51.290486 | access_policy) 2017-09-06 18:33:51.290527 | File "/home/jenkins/workspace/gate-cross-cinder-python27-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/oslo_messaging/rpc/dispatcher.py", line 155, in __init__ 2017-09-06 18:33:51.290555 | target = getattr(ep, 'target', None) 2017-09-06 18:33:51.290576 | File "cinder/tests/unit/test_test.py", line 42, in __getattribute__ 2017-09-06 18:33:51.290592 | self.fail(msg="I should never get called.") 2017-09-06 18:33:51.290648 | File "/home/jenkins/workspace/gate-cross-cinder-python27-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/unittest2/case.py", line 690, in fail 2017-09-06 18:33:51.290666 | raise self.failureException(msg) 2017-09-06 18:33:51.290681 | AssertionError: I should never get called. https://github.com/openstack/oslo.messaging/compare/5.30.0...5.31.0 My guess is this change breaks the test: https://github.com/openstack/oslo.messaging/commit/b7382d58d773e9be61dda3fac5b2e3cbddc22a22 To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1715470/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
