Public bug reported: Occasionally an API (i.e. DELETE /v3/domains/<domain_id>) receives an HTTP 500 response. However, all we got from keystone log is this
2017-09-12 23:20:37.995 7321 WARNING keystone.common.wsgi [req-e1060272-c8b8-4d51-94f5-98b2b4d84a43 960c1d5dba8847cfbde96764ee7747bb - default default -] An unexpected error prevented the server from fulfilling your request. No traceback. No other helpful messages as to what had caused the HTTP 500. With HTTP 500, I would expect a handsome looking traceback in the keystone log. So diving into the code, I do see we log the exception if an unexpected error is raise. https://github.com/openstack/keystone/blob/master/keystone/common/wsgi.py#L248 But, if the error is exception.UnexceptionError, we don't log the exception. We merely log it as a warning. https://github.com/openstack/keystone/blob/master/keystone/common/wsgi.py#L238 Notice that expection.UnexpectedError is an instance of exception.Error. https://github.com/openstack/keystone/blob/master/keystone/exception.py#L474 So we have a couple of choices. 1. Find all the places where exception.UnexpectedError is raised. Log something meaningful/actionable prior to raising it. 2. Add a couple of line of code here, https://github.com/openstack/keystone/blob/master/keystone/common/wsgi.py#L238, to log the traceback/exception if e is also an instance of error.UnexpectedError. ** Affects: keystone Importance: Undecided Status: New -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Identity (keystone). https://bugs.launchpad.net/bugs/1717962 Title: Unhelpful error in the keystone log Status in OpenStack Identity (keystone): New Bug description: Occasionally an API (i.e. DELETE /v3/domains/<domain_id>) receives an HTTP 500 response. However, all we got from keystone log is this 2017-09-12 23:20:37.995 7321 WARNING keystone.common.wsgi [req-e1060272-c8b8-4d51-94f5-98b2b4d84a43 960c1d5dba8847cfbde96764ee7747bb - default default -] An unexpected error prevented the server from fulfilling your request. No traceback. No other helpful messages as to what had caused the HTTP 500. With HTTP 500, I would expect a handsome looking traceback in the keystone log. So diving into the code, I do see we log the exception if an unexpected error is raise. https://github.com/openstack/keystone/blob/master/keystone/common/wsgi.py#L248 But, if the error is exception.UnexceptionError, we don't log the exception. We merely log it as a warning. https://github.com/openstack/keystone/blob/master/keystone/common/wsgi.py#L238 Notice that expection.UnexpectedError is an instance of exception.Error. https://github.com/openstack/keystone/blob/master/keystone/exception.py#L474 So we have a couple of choices. 1. Find all the places where exception.UnexpectedError is raised. Log something meaningful/actionable prior to raising it. 2. Add a couple of line of code here, https://github.com/openstack/keystone/blob/master/keystone/common/wsgi.py#L238, to log the traceback/exception if e is also an instance of error.UnexpectedError. To manage notifications about this bug go to: https://bugs.launchpad.net/keystone/+bug/1717962/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
