Reviewed: https://review.openstack.org/505316 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d739d01b6c98e082127af8fa6d4130e854ff413d Submitter: Jenkins Branch: master
commit d739d01b6c98e082127af8fa6d4130e854ff413d Author: Jakub Libosvar <libos...@redhat.com> Date: Tue Sep 19 15:54:56 2017 +0000 of_native: Use int for comparing datapath ID Previously, DP ID was converted to integer and then back to string. As a consequence of the conversion, DP IDs like 000123 were converted to 123 losing leading zeros. In case self._get_dp_by_dpid() method raises a RuntimeError exception current DP ID of the bridge was compared to cached DP ID and if IDs were different, original exception coming from ryu library was swallowed. As conversion for cached DP ID removes leading zeros, original exception was always swallowed if bridge's DP ID started with zero. This patch uses the integer for comparison between current and cached bridge DP ID hence any exception coming from ryu is not swallowed. Closes-bug: #1718235 Change-Id: I445aa61acc758b56c51a9403df4d92d9c1d40ace ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1718235 Title: ovs_bridge native doesn't reraise RuntimeError if _get_dp_by_dpid fails Status in neutron: Fix Released Bug description: Typically DPID starts with zeros while code trims the prefixed zeros and then comparison fails masking the real OVS failure. To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1718235/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp