Reviewed: https://review.openstack.org/507687 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f90c61cd88edce74e3dbfd069beb2c33793d3371 Submitter: Jenkins Branch: master
commit f90c61cd88edce74e3dbfd069beb2c33793d3371 Author: Matt Riedemann <[email protected]> Date: Tue Sep 26 17:37:19 2017 -0400 Remove dest node allocations during live migration rollback When a live migration fails or is cancelled, either during pre_live_migration on the destination host or during the actual live migration itself, we rollback from the failure/abort by doing things like removing volume connections from the destination host and re-setup the network on the source host. As part of the rollback from a failed or cancelled live migration, we also need to remove the allocations created in Placement for the destination node, since the instance is not on the destination node. Change-Id: I7b70cf8d5233bd25bf865a1b2789640758493c2b Closes-Bug: #1715182 Closes-Bug: #1714237 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1715182 Title: _rollback_live_migration does not remove allocations from destination node Status in OpenStack Compute (nova): Fix Released Status in OpenStack Compute (nova) pike series: In Progress Bug description: This is a follow on to bug 1712411 where pre_live_migration fails on the destination host here: https://github.com/openstack/nova/blob/0e52b3fe686ce1fc43fd3790711731bc806c6ad0/nova/compute/manager.py#L5456 And the source node starts rolling back things like volume connections on the destination host: https://github.com/openstack/nova/blob/0e52b3fe686ce1fc43fd3790711731bc806c6ad0/nova/compute/manager.py#L5836 The tricky thing is we maybe can't cleanup the allocations from the _rollback_live_migration method since that's also passed to the virt driver in case live migration fails in the driver: https://github.com/openstack/nova/blob/0e52b3fe686ce1fc43fd3790711731bc806c6ad0/nova/compute/manager.py#L5467 We might be unsure of what is actually running on the destination node and consuming resources at that point, however, the instance.host and instance.node should be pointed to the source node at that point of failure anyway, so removing the allocations on the destination node from within _rollback_live_migration should be OK, but it might require some investigation. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1715182/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
