Reviewed: https://review.openstack.org/468538 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=de34bc380c6fb49e9d6f78cdfb11ac57d3c20771 Submitter: Jenkins Branch: master
commit de34bc380c6fb49e9d6f78cdfb11ac57d3c20771 Author: Matt Wisch <[email protected]> Date: Fri May 26 16:35:09 2017 -0400 Clarify conf/compute.py help text for ListOpts The compute_monitors setting help gave an example of providing multiple drivers via the python list format. As the config was loaded, this caused the list to be nested within a list. The non_inheritable_image_properties help also gave an example in python list format when it should be a comma-separated list. Updated the help to show that the compute_monitors and non_inheritable_image_properties driver settings should be provided in a comma delimited format if multiple values are provided. Change-Id: Ie07892cfde90d1679e941611e1dfbf0c011e1d1b Closes-Bug: #1693923 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1693923 Title: compute_monitors help incorrectly shows multiple values in a list Status in OpenStack Compute (nova): Fix Released Bug description: This issue was actually nicely written up here: https://iclykofte.com /physical-host-metrics-in-ceilometer-an-openstack-liberty-tale/ ...but apparently never made it into a bug/patch. If you supply more than one driver to compute_monitors in a list per the setting help, the list will be nested inside another list (cfg_monitors). Steps to reproduce: 1) set /etc/nova/nova.conf DEFAULT compute_monitors to ["cpu.virt_driver", "numa_mem_bw.virt_driver"] 2) in nova-manage shell, load the config, and populate the cfg_monitors list 3) cfg_monitors will = ['nova.compute.monitors.["cpu.virt_driver"', 'nova.compute.monitors."numa_mem_bw.virt_driver"]'] Expected result: cfg_monitors = ['nova.compute.monitors.cpu.virt_driver', 'nova.compute.monitors.cpu.numa_mem_bw.virt_driver'] This can be achieved by setting compute_monitors = cpu.virt_driver, numa_mem_bw.virt_driver To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1693923/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
