Reviewed: https://review.openstack.org/516662 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f974e3c3566f379211d7fdc790d07b5680925584 Submitter: Zuul Branch: master
commit f974e3c3566f379211d7fdc790d07b5680925584 Author: Chris Dent <[email protected]> Date: Tue Oct 31 12:54:17 2017 +0000 [placement] avoid case issues microversions in gabbits If a gabbi file sets a default microversion by setting a header 'OpenStack-API-Version' with a value like 'placement latest' and then later overrides that in an individual test with a header of 'openstack-api-version' the difference in case can lead to failure. In the best case the failure is consistent. In the worst case it can sometimes work, because the header shows up twice in the request, and the last header wins, order in the headers and the resulting list dependent on the vagrancies of python ordering. The solution is to always use the same case, so this change updates all use to be lowercase, to establish a precedent that future people will be able to use as an example. Note that gabbi is case sensitive here in part because of the implementation but also because it provides the control and possibility to test exactly this problem. Change-Id: I1e89e231cf0d46d211d360cda091b33520f85027 Closes-Bug: #1728934 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1728934 Title: placement gabbi tests that manipulate microversion can intermittently fail Status in OpenStack Compute (nova): Fix Released Bug description: If a gabbi file sets a default microversion by setting a header 'OpenStack-API-Version' with a value like 'placement latest' and then later overrides that in an individual test with a header of 'openstack-api-version' the difference in case can lead to failure. In the best case the failure is consistent. In the worst case it can sometimes work, because the header shows up twice in the request, and the last header wins. The solution is to always use the same case through the file. Note that gabbi is case sensitive here in part because of the implementation but also because it provides control and possibility to test exactly this problem. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1728934/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
