Reviewed:  https://review.openstack.org/513639
Committed: 
https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=045c0b18f440db68157a0be0275ddf9eac40ea93
Submitter: Zuul
Branch:    master

commit 045c0b18f440db68157a0be0275ddf9eac40ea93
Author: ycx <ya...@awcloud.com>
Date:   Fri Oct 20 15:33:19 2017 +0800

    Modify the validator for segmentation_id 0
    
    When supplying a subport for a trunk with segmenation_id 0, Neutron
    reports the error message about subport.
    This patch lets the segmentation_id 0 pass through.
    
    Change-Id: I3d164c1a1af89d7de20d90b3a6c6dcf6e8a1415b
    Closes-bug: 1718385


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1718385

Title:
  invalid segmentation_id 0 does not return friendly error

Status in neutron:
  Fix Released

Bug description:
  When supplying a subport for a trunk with segmenation_id 0 Neutron
  reports:

  Invalid subport details '{u'segmentation_type': u'vlan', u'port_id':
  u'449451c4-f134-4fbc-b405-df9109746e51', u'segmentation_id': 0}':
  missing segmentation information. Must specify both segmentation_id
  and segmentation_type from (pid=16359) validate_subports
  /Ocata/local/lib/python2.7/site-
  packages/neutron_lib/api/validators.py:923

  This is due to the following lines: 
          segmentation_id = subport.get("segmentation_id")
          segmentation_type = subport.get("segmentation_type")
          if (not segmentation_id or not segmentation_type) and len(subport) > 
1:

  Can we allow segmentation_id 0 to pass or provide a more suitable
  error message?

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1718385/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to     : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp

Reply via email to