Reviewed: https://review.openstack.org/515034 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=32fd58813f8247641a6b574b5f01528b29d48b76 Submitter: Zuul Branch: master
commit 32fd58813f8247641a6b574b5f01528b29d48b76 Author: Surya Seetharaman <[email protected]> Date: Wed Oct 25 13:43:43 2017 +0200 cleanup mapping/reqspec after archive instance This patch aims at deleting the records of the archived instances from the instance_mappings and request_specs tables in the API database immediately following their archival from instances to shadow_instances table. So upon running the 'nova-manage db archive_deleted_rows' command the records of the archived instances will be automatically removed from the instance_mappings and request_specs tables as well. A warning has also been added to fix the issue of 'nova-manage verify_instance' returning a valid instance mapping even after the instance is deleted. The patch also adds InstanceMappingList.destory_bulk() and RequestSpec.destroy_bulk() methods for ease of bulk deletion of records. Change-Id: I483701a55576c245d091ff086b32081b392f746e Closes-Bug: #1724621 Closes-Bug: #1678056 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1724621 Title: nova-manage cell_v2 verify_instance returns a valid instance mapping even after the instance is deleted/archived Status in OpenStack Compute (nova): Fix Released Bug description: Although nova-manage cell_v2 verify_instance is used to check if the provided instance is correctly mapped to a cell or not, this should not be returning a valid mapping message if the instance itself is deleted. It should return an error message saying 'The instance does not exist'. Steps to reproduce : 1. Create an instance : -> nova boot --image 831bb8a0-9305-4cd7-b985-cbdadfb5d3db --flavor m1.nano test -> nova list +--------------------------------------+--------+--------+------------+-------------+---------------------------------+ | ID | Name | Status | Task State | Power State | Networks | +--------------------------------------+--------+--------+------------+-------------+---------------------------------+ | aec6eb34-6aaf-4883-8285-348d40fdac87 | test | ACTIVE | - | Running | public=2001:db8::4, 172.24.4.9 | +--------------------------------------+--------+--------+------------+-------------+---------------------------------+ 2. Delete the instance : -> nova delete test Request to delete server test has been accepted. -> nova list +--------------------------------------+--------+--------+------------+-------------+---------------------------------+ | ID | Name | Status | Task State | Power State | Networks | +--------------------------------------+--------+--------+------------+-------------+---------------------------------+ +--------------------------------------+--------+--------+------------+-------------+---------------------------------+ 3. Verify Instance : -> nova-manage cell_v2 verify_instance --uuid aec6eb34-6aaf-4883-8285-348d40fdac87 Instance aec6eb34-6aaf-4883-8285-348d40fdac87 is in cell: cell5 (c5ccba5d-1a45-4739-a5dd-d665a1b19301) Basically the message that we get is misleading for a deleted instance. This is because verify_instance queries the instance_mappings table which maintains a mapping of the deleted instances as well. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1724621/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
