Reviewed: https://review.openstack.org/520579 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ff4f58fcd279605998de21405facb2cfcf8ba385 Submitter: Zuul Branch: master
commit ff4f58fcd279605998de21405facb2cfcf8ba385 Author: Balazs Gibizer <[email protected]> Date: Thu Nov 16 13:55:39 2017 +0100 Fix the usage of instance.snapshot notification sample The instance.snapshot.start and .end notification sample file was attached to two different Notification ovo by mistake. This caused that the samples are appeared in the notification dev-ref twice. This patch removes the duplication and adds a simple check to the doc generation code to detech such problems in the future. Change-Id: I8478c134f9cdb08c02a44e1838dbacede5523914 Closes-Bug: #1732685 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1732685 Title: instance.snapshot notification samples are assigned to two different Notification classes Status in OpenStack Compute (nova): Fix Released Bug description: Here attached to the wrong class: https://github.com/openstack/nova/blob/b28924b8e4115f436d46812877066d5d03ad272a/nova/notifications/objects/instance.py#L414-L415 Here attached to the correct class: https://github.com/openstack/nova/blob/b28924b8e4115f436d46812877066d5d03ad272a/nova/notifications/objects/instance.py#L522-L523 This causes that the sample will appear twice in the table of versioned notifications in the devref: https://docs.openstack.org/nova/latest/reference/notifications.html #existing-versioned-notifications It also makes both occurrences shown by default instead of hidden as the rest of the sample by default. The bug only effects the master branch as the patch https://review.openstack.org/#/c/453077/ that caused this was merged after Pike. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1732685/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
