Public bug reported: ImageSizeLimitExceeded exception block [1] is unreachable in upload because it is caught at [1] and raised StorageQuotaFull exception from there.
Further as it raised StorageQuataFull exception it prints None as a size in the glance-api logs. Reference glance-api-logs: Nov 28 07:04:13 devstack devstack@g-api.service[11453]: ERROR glance.api.v2.image_data [None req-17b243db-9b3d-46d9-97f0-05f74bc76e18 admin admin] Image exceeds the storage quota: The size of the data None will exceed the limit. None bytes remaining.: StorageQuotaFull: The size of the data None will exceed the limit. None bytes remaining. To make it correct we need to remove code from [2] where ImageSizeLimitExceeded is caught and StorageQuotaFull is raised so that it will be reachable in the controller [1]. [1] https://github.com/openstack/glance/blob/master/glance/api/v2/image_data.py#L232 [2] https://github.com/openstack/glance/blob/master/glance/quota/__init__.py#L305 ** Affects: glance Importance: Undecided Assignee: Abhishek Kekane (abhishek-kekane) Status: New ** Changed in: glance Assignee: (unassigned) => Abhishek Kekane (abhishek-kekane) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to Glance. https://bugs.launchpad.net/bugs/1734832 Title: Unreachable 'ImageSizeLimitExceeded' exception block in upload call Status in Glance: New Bug description: ImageSizeLimitExceeded exception block [1] is unreachable in upload because it is caught at [1] and raised StorageQuotaFull exception from there. Further as it raised StorageQuataFull exception it prints None as a size in the glance-api logs. Reference glance-api-logs: Nov 28 07:04:13 devstack devstack@g-api.service[11453]: ERROR glance.api.v2.image_data [None req-17b243db-9b3d-46d9-97f0-05f74bc76e18 admin admin] Image exceeds the storage quota: The size of the data None will exceed the limit. None bytes remaining.: StorageQuotaFull: The size of the data None will exceed the limit. None bytes remaining. To make it correct we need to remove code from [2] where ImageSizeLimitExceeded is caught and StorageQuotaFull is raised so that it will be reachable in the controller [1]. [1] https://github.com/openstack/glance/blob/master/glance/api/v2/image_data.py#L232 [2] https://github.com/openstack/glance/blob/master/glance/quota/__init__.py#L305 To manage notifications about this bug go to: https://bugs.launchpad.net/glance/+bug/1734832/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
