Reviewed: https://review.openstack.org/517149 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d16f750b36db3f220bca63e8fab509074e49ed6d Submitter: Zuul Branch: master
commit d16f750b36db3f220bca63e8fab509074e49ed6d Author: Ivan Udovichenko <[email protected]> Date: Thu Nov 2 04:22:34 2017 +0300 Raise detailed exception This change allows to throw a detailed exception in case if 'files' list has 'None' value: """ Exception occurred: File "/<<PKGBUILDDIR>>/openstack_dashboard/utils/\ settings.py", line 263, in get_xstatic_dirs for file in files: TypeError: 'NoneType' object is not iterable """ Closes-Bug: #1732567 Change-Id: Iaf6282819c26c12ca24d19ef7dee00a5c8586418 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1732567 Title: get_xstatic_dirs do not process None values in BASE_XSTATIC_MODULES Status in OpenStack Dashboard (Horizon): Fix Released Bug description: The issue was noticed during package build: """ ./run_tests.sh --no-virtual-env --no-pep8 --verbosity=2 The run_tests script is deprecated and will be removed in the Queens Release Cycle (13.0), in favor of tox. Running Horizon application tests Traceback (most recent call last): File "/<<PKGBUILDDIR>>/manage.py", line 23, in <module> execute_from_command_line(sys.argv) File "/usr/lib/python2.7/dist-packages/django/core/management/__init__.py", line 354, in execute_from_command_line utility.execute() File "/usr/lib/python2.7/dist-packages/django/core/management/__init__.py", line 303, in execute settings.INSTALLED_APPS File "/usr/lib/python2.7/dist-packages/django/conf/__init__.py", line 48, in __getattr__ self._setup(name) File "/usr/lib/python2.7/dist-packages/django/conf/__init__.py", line 44, in _setup self._wrapped = Settings(settings_module) File "/usr/lib/python2.7/dist-packages/django/conf/__init__.py", line 92, in __init__ mod = importlib.import_module(self.SETTINGS_MODULE) File "/usr/lib/python2.7/importlib/__init__.py", line 37, in import_module __import__(name) File "/<<PKGBUILDDIR>>/horizon/test/settings.py", line 142, in <module> settings_utils.BASE_XSTATIC_MODULES, HORIZON_CONFIG File "/<<PKGBUILDDIR>>/openstack_dashboard/utils/settings.py", line 263, in get_xstatic_dirs for file in files: TypeError: 'NoneType' object is not iterable Running openstack_dashboard tests Traceback (most recent call last): File "/<<PKGBUILDDIR>>/manage.py", line 23, in <module> execute_from_command_line(sys.argv) File "/usr/lib/python2.7/dist-packages/django/core/management/__init__.py", line 354, in execute_from_command_line utility.execute() File "/usr/lib/python2.7/dist-packages/django/core/management/__init__.py", line 303, in execute settings.INSTALLED_APPS File "/usr/lib/python2.7/dist-packages/django/conf/__init__.py", line 48, in __getattr__ self._setup(name) File "/usr/lib/python2.7/dist-packages/django/conf/__init__.py", line 44, in _setup self._wrapped = Settings(settings_module) File "/usr/lib/python2.7/dist-packages/django/conf/__init__.py", line 92, in __init__ mod = importlib.import_module(self.SETTINGS_MODULE) File "/usr/lib/python2.7/importlib/__init__.py", line 37, in import_module __import__(name) File "/<<PKGBUILDDIR>>/openstack_dashboard/test/settings.py", line 19, in <module> from horizon.test.settings import * # noqa: F403,H303 File "/<<PKGBUILDDIR>>/horizon/test/settings.py", line 142, in <module> settings_utils.BASE_XSTATIC_MODULES, HORIZON_CONFIG File "/<<PKGBUILDDIR>>/openstack_dashboard/utils/settings.py", line 263, in get_xstatic_dirs for file in files: TypeError: 'NoneType' object is not iterable Tests failed. """ This is a default configuration without additional changes. http://paste.openstack.org/show/erxuvARQtXgWTmDnkECd/ Proposed fix: https://review.openstack.org/517149 To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1732567/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
