Reviewed: https://review.openstack.org/525983
Committed:
https://git.openstack.org/cgit/openstack/neutron/commit/?id=5da1a6f7c62893c2301f52f0f09b551b7fc8c525
Submitter: Zuul
Branch: master
commit 5da1a6f7c62893c2301f52f0f09b551b7fc8c525
Author: Gary Kotton <gkot...@vmware.com>
Date: Wed Dec 6 00:32:24 2017 -0800
Tags: harden validations
An invalid input would cause a server execption. We now validate
that the body in the tags validation is not None.
TrivialFix
Change-Id: I97a00ee6d2672485334bba757706f107e052b551
Closes-Bug: #1736678
** Changed in: neutron
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1736678
Title:
Tags: server exception when using invalid tag inputs
Status in neutron:
Fix Released
Bug description:
Dec 05 20:08:36 utu1604template devstack@keystone.service[11631]: DEBUG
keystone.common.authorization [None req-8d8b3040-9dc4-4bf0-acfd-b1df1e929ca6
None None] RBAC: Authorizing identity:validate_token() {{(pid=11634)
_build_policy_check_credentials
/opt/stack/keystone/keystone/common/authorization.py:137}}
Dec 05 20:08:36 utu1604template devstack@keystone.service[11631]: DEBUG
keystone.policy.backends.rules [None req-8d8b3040-9dc4-4bf0-acfd-b1df1e929ca6
None None] enforce identity:validate_token: {'is_delegated_auth': False,
'access_token_id': None, 'user_id': u'5fc8eb4a128b426a8f0d64fb282c89ff',
'roles': [u'service'], 'user_domain_id': u'default', 'consumer_id': None,
'trustee_id': None, 'is_domain': False, 'is_admin_project': True, 'trustor_id':
None, 'token': <KeystoneToken (audit_id=kupMJxgiRYur9e1UJJycpg,
audit_chain_id=kupMJxgiRYur9e1UJJycpg) at 0x7fe3edff6868>, 'project_id':
u'63dfd8edb7a744689f5a4e1d72b168c0', 'trust_id': None, 'project_domain_id':
u'default'} {{(pid=11634) enforce
/opt/stack/keystone/keystone/policy/backends/rules.py:33}}
Dec 05 20:08:36 utu1604template devstack@keystone.service[11631]: DEBUG
keystone.common.authorization [None req-8d8b3040-9dc4-4bf0-acfd-b1df1e929ca6
None None] RBAC: Authorization granted {{(pid=11634) check_policy
/opt/stack/keystone/keystone/common/authorization.py:240}}
Dec 05 20:08:36 utu1604template devstack@keystone.service[11631]: [pid:
11634|app: 0|req: 26017/52064] 10.115.78.247 () {62 vars in 1404 bytes} [Tue
Dec 5 20:08:36 2017] GET /identity/v3/auth/tokens => generated 3584 bytes in 48
msecs (HTTP/1.1 200) 6 headers in 380 bytes (1 switches on core 0)
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation [None
req-43a734a1-1e9c-4b32-9fba-e906c983ade3 tempest-NetworkTagAddTest-4314208
tempest-NetworkTagAddTest-4314208] PUT failed.: TypeError: argument of type
'NoneType' is not iterable
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation Traceback (most recent call last):
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation File
"/usr/local/lib/python2.7/dist-packages/pecan/core.py", line 683, in __call__
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation self.invoke_controller(controller, args,
kwargs, state)
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation File
"/usr/local/lib/python2.7/dist-packages/pecan/core.py", line 574, in
invoke_controller
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation result = controller(*args, **kwargs)
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation File
"/opt/stack/neutron/neutron/db/api.py", line 93, in wrapped
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation setattr(e, '_RETRY_EXCEEDED', True)
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation File
"/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 220, in
__exit__
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation self.force_reraise()
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation File
"/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 196, in
force_reraise
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation six.reraise(self.type_, self.value,
self.tb)
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation File
"/opt/stack/neutron/neutron/db/api.py", line 89, in wrapped
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation return f(*args, **kwargs)
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation File
"/usr/local/lib/python2.7/dist-packages/oslo_db/api.py", line 150, in wrapper
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation ectxt.value = e.inner_exc
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation File
"/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 220, in
__exit__
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation self.force_reraise()
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation File
"/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 196, in
force_reraise
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation six.reraise(self.type_, self.value,
self.tb)
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation File
"/usr/local/lib/python2.7/dist-packages/oslo_db/api.py", line 138, in wrapper
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation return f(*args, **kwargs)
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation File
"/opt/stack/neutron/neutron/db/api.py", line 128, in wrapped
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation LOG.debug("Retry wrapper got retriable
exception: %s", e)
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation File
"/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 220, in
__exit__
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation self.force_reraise()
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation File
"/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 196, in
force_reraise
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation six.reraise(self.type_, self.value,
self.tb)
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation File
"/opt/stack/neutron/neutron/db/api.py", line 124, in wrapped
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation return f(*dup_args, **dup_kwargs)
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation File
"/opt/stack/neutron/neutron/pecan_wsgi/controllers/utils.py", line 76, in
wrapped
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation return f(*args, **kwargs)
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation File
"/opt/stack/neutron/neutron/pecan_wsgi/controllers/utils.py", line 398, in index
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation result = controller_method(*args,
**uri_identifiers)
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation File
"/opt/stack/neutron/neutron/extensions/tagging.py", line 136, in update_all
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation validate_tags(body)
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation File
"/opt/stack/neutron/neutron/extensions/tagging.py", line 74, in validate_tags
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation if 'tags' not in body:
Dec 05 20:08:36 utu1604template neutron-server[19677]: ERROR
neutron.pecan_wsgi.hooks.translation TypeError: argument of type 'NoneType' is
not iterable
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1736678/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
