Reviewed: https://review.openstack.org/507388 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f929d39ab471e2462a2bfcd35d880e2aafb724bb Submitter: Zuul Branch: master
commit f929d39ab471e2462a2bfcd35d880e2aafb724bb Author: Huan Xiong <[email protected]> Date: Tue Sep 26 14:38:55 2017 +0800 Do not make duplicate requests to Glance for image names in admin panel Admin panel generates duplicate (N per instance) requests to Glance for instances that boot from image. The commit fixes it by getting all images information in one shot. Change-Id: I360aef8c34304f3abe76a90787ab63647cd78491 Closes-Bug: #1711486 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1711486 Title: Admin dashboard instances index page generated duplicate Glance requests Status in OpenStack Dashboard (Horizon): Fix Released Bug description: Please see this thread: http://lists.openstack.org/pipermail/openstack- dev/2017-August/121097.html The instances index page in Admin dashboard generates a request for Glance every time Server.image_name() is called (the method is called a lot when building the page). Project dashboard doesn't have this issue because it retrieves all images objects first and sets each instance's image attribute to corresponding image object. From what I searched in commit log, the support in Project dash board was introduced in bd6bad5f. df194c8b (integrated early this year) patched Admin dashboard's index page to retrieve image objects but didn't set instances' image attribute to corresponding image object. BTW, it's not clear in Glance API doc if user with admin role can get all project images (including project private ones) when issuing "GET /v2/images" reqeust, but my experiments verified it can. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1711486/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
