Reviewed:  https://review.openstack.org/505471
Committed: 
https://git.openstack.org/cgit/openstack/nova/commit/?id=0be601a136374257cdd650279c7373adced111ce
Submitter: Zuul
Branch:    master

commit 0be601a136374257cdd650279c7373adced111ce
Author: jichenjc <[email protected]>
Date:   Sat Sep 16 01:55:24 2017 +0800

    Fix warning on {'cell_id': 1} is an invalid UUID
    
    The functional test mock assume args[-1] always be instance_uuid
    but actually it's not, when _save_db it might contains some changes
    on the instance_mapping.
    
    some test functions were reused in order to avoid display warning.
    
    Change-Id: I90afca7f426f5c9fd14051df6fb0a8b45cd0833d
    Closes-Bug: 1718325


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1718325

Title:
  {'cell_id': 1} is an invalid UUID in functional test

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  functional test has following warning, it turn out the assumption has
  some error on mocks

  
/home/jichen/git/nova/.tox/functional/local/lib/python2.7/site-packages/oslo_versionedobjects/fields.py:365:
 FutureWarning: attr instance_uuid {'cell_id': 1} is an invalid UUID. Using 
UUIDFields with invalid UUIDs is no longer supported, and will be removed in a 
future release. Please update your code to input valid UUIDs or accept 
ValueErrors for invalid UUIDs. See 
https://docs.openstack.org/oslo.versionedobjects/latest/reference/fields.html#oslo_versionedobjects.fields.UUIDField
 for further details
    "for further details" % (attr, value), FutureWarning)


  > /home/jichen/git/nova/nova/tests/fixtures.py(318)_fake_instancemapping_get()
  -> uuid = args[-1]
  (Pdb) p args
  (<nova.context.RequestContext object at 0xeb4418c>, 
'fae9049d-4633-4148-9917-bb680dd2d413', {'cell_id': 1})
  (Pdb) l
  313                     'cell_mapping': self._fake_cell_list()[0]}
  314
  315         def _fake_instancemapping_get(self, *args):
  316             import pdb
  317             pdb.set_trace()
  318  ->         uuid = args[-1]
  319             cell_id = None

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1718325/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp

Reply via email to