Reviewed: https://review.openstack.org/535219 Committed: https://git.openstack.org/cgit/openstack/osprofiler/commit/?id=79e4e2de42e61556f6da251f351e56cadb07fe6d Submitter: Zuul Branch: master
commit 79e4e2de42e61556f6da251f351e56cadb07fe6d Author: Tovin Seven <[email protected]> Date: Thu Jan 18 15:22:07 2018 +0700 Check profiler instance before initialize Add a small check for this to an prevent issue in Nova [1] that causes some commands not working. [1] http://paste.openstack.org/show/641262/ Change-Id: I685386695e13bf5034a1008dbdcff4539eb482d2 Closes-Bug: #1743586 ** Changed in: osprofiler Status: New => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1743586 Title: Nova operations fail when profiling is enabled Status in OpenStack Compute (nova): New Status in osprofiler: Fix Released Bug description: Nova server-related operations fail with HTTP 500 when executed with profiling. Nova server log contains error "IndexError: pop from an empty deque" and stack trace pointing to osprofiler code: ERROR nova.api.openstack File "/opt/stack/osprofiler/osprofiler/web.py", line 132, in __call__ ERROR nova.api.openstack return request.get_response(self.application) ERROR nova.api.openstack File "/opt/stack/osprofiler/osprofiler/profiler.py", line 348, in __exit__ ERROR nova.api.openstack stop() ERROR nova.api.openstack File "/opt/stack/osprofiler/osprofiler/profiler.py", line 87, in stop ERROR nova.api.openstack profiler.stop(info=info) ERROR nova.api.openstack File "/opt/stack/osprofiler/osprofiler/profiler.py", line 406, in stop ERROR nova.api.openstack self._notify("%s-stop" % self._name.pop(), info) Steps to reproduce: 0. Take the latest Devstack with osprofiler enabled. 1. Execute `openstack --os-profile SECRET_KEY server list` Observed behavior: $ openstack --os-profile SECRET_KEY server list The server has either erred or is incapable of performing the requested operation. (HTTP 500) (Request-ID: req-73de8073-94b7-44f0-96ca-5a0c5979636c) Trace ID: 5f0d7147-6e15-41c4-a61b-84f74e3787d4 Display trace with command: osprofiler trace show --html 5f0d7147-6e15-41c4-a61b-84f74e3787d4 To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1743586/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
