Public bug reported: The PowerVM virt driver is passing the instance as the first argument to the Task init in a few places [1] [2]. The init method [3] expects the first arg to be the task name. This results in the task name being the string representation of the instance. The instance should no longer be passed into the Task init and the task names should be passed to the init using the name kwarg.
This doesn't break the typical flows, however if the instance has any non-ascii characters in the string representation, the task will fail to compile. This affects queens and master branches using the PowerVM virt driver. [1] https://github.com/openstack/nova/blob/17.0.0.0rc1/nova/virt/powervm/tasks/storage.py#L160 [2] https://github.com/openstack/nova/blob/17.0.0.0rc1/nova/virt/powervm/tasks/storage.py#L200 [3] https://github.com/openstack/taskflow/blob/3.1.0/taskflow/task.py#L62 ** Affects: nova Importance: Undecided Assignee: Eric Berglund (esberglu) Status: New ** Changed in: nova Assignee: (unassigned) => Eric Berglund (esberglu) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1748950 Title: PowerVM driver passing bad kwargs into Task init method Status in OpenStack Compute (nova): New Bug description: The PowerVM virt driver is passing the instance as the first argument to the Task init in a few places [1] [2]. The init method [3] expects the first arg to be the task name. This results in the task name being the string representation of the instance. The instance should no longer be passed into the Task init and the task names should be passed to the init using the name kwarg. This doesn't break the typical flows, however if the instance has any non-ascii characters in the string representation, the task will fail to compile. This affects queens and master branches using the PowerVM virt driver. [1] https://github.com/openstack/nova/blob/17.0.0.0rc1/nova/virt/powervm/tasks/storage.py#L160 [2] https://github.com/openstack/nova/blob/17.0.0.0rc1/nova/virt/powervm/tasks/storage.py#L200 [3] https://github.com/openstack/taskflow/blob/3.1.0/taskflow/task.py#L62 To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1748950/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
