Reviewed: https://review.openstack.org/539506 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5895566a428be4c30c31ae94070282566a6cc568 Submitter: Zuul Branch: master
commit 5895566a428be4c30c31ae94070282566a6cc568 Author: Mark Goddard <[email protected]> Date: Wed Jan 31 11:11:32 2018 +0000 Add resource_class to fields in ironic node cache Per the discussion in [1], the ironic nodes added to the node cache in the ironic virt driver may be missing the required field resource_class, as this field is not in _NODE_FIELDS. In practice, this is typically not an issue (possibly never), as the normal code path uses a detailed list to sync all ironic nodes, which contain all fields (including resource_class). However, some code paths use a single node query with the fields limited to _NODE_FIELDS, so could result in a node in the cache without a resource_class. This change adds resource_class to _NODE_FIELDS. [1] https://review.openstack.org/#/c/532288/9/nova/virt/ironic/driver.py@79 Change-Id: Id84b4a47d05532d341a9b6ca2de7e9e66e1930da Closes-Bug: #1746209 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1746209 Title: Ironic virt driver node cache may be missing required fields Status in OpenStack Compute (nova): Fix Released Status in OpenStack Compute (nova) queens series: Confirmed Bug description: Per the discussion in [1], the ironic nodes added to the node cache in the ironic virt driver may be missing the required field resource_class, as this field is not in _NODE_FIELDS. In practice, this is typically not an issue (possibly never), as the normal code path uses a detailed list to sync all ironic nodes, which contain all fields (including resource_class). However, some code paths use a single node query with the fields limited to _NODE_FIELDS, so this should be changed to include the required resource_class. There are a number of other minor related issues picked up in that discussion, which don't really deserve their own bugs: * Filter the node list in _refresh_cache using _NODE_FIELDS. * Improve unit tests to use representative filtered node objects. * Remove _parse_node_instance_info and associated tests. [1] https://review.openstack.org/#/c/532288/9/nova/virt/ironic/driver.py@79 To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1746209/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
