All proposed patches have been merged. Let's mark it as Fix Released.

** Changed in: horizon
       Status: In Progress => Fix Released

** Changed in: horizon
    Milestone: None => rocky-1

You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).

  inappropriate mocking in

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Tests under openstack_dashboard/test/unit/api/rest mocks the whole API 
modules like @mock.patch.patch(api, 'neutron').
  It is not an appropriate mocking. We should mock only methods we really 
expect to call.

  In addition, there are several points to be improved in these tests.

  - Unnecessary usage of test.mock_factory(). Test data can be used directly.
  - Related to the above, setUp() is unnecessary because they are used to 
prepare data with mock_factory.
  - Test data should be accessed via something like self.networks.list() rather 
than calling TestData directly.

To manage notifications about this bug go to:

Mailing list:
Post to     :
Unsubscribe :
More help   :

Reply via email to