Per comment 2 on cleaning up the port when we shelve offload, it sounds like that should be OK to do:
(2:30:17 PM) mriedem: mlavalle: while working on bug 1759924 - i'm trying to determine if neutron would have any issues with a port attached to a vm where the binding host and device_owner are unset? (2:30:19 PM) openstack: bug 1759924 in OpenStack Compute (nova) "Port device owner isn't updated with new host availability zone during unshelve" [Medium,Triaged] https://launchpad.net/bugs/1759924 - Assigned to Matt Riedemann (mriedem) (2:30:44 PM) mriedem: can you think of anything off the top of your head that might break there? (2:30:58 PM) mriedem: this is when an instance is shelved, meaning there is no actual guest running in a hypervisor (2:34:07 PM) mlavalle: mriedem: in that situation the port is not bound so it doesn't exist in a host. Am I understanding correctly? (2:34:44 PM) mriedem: correct, nova would unplug the vif (2:34:45 PM) mriedem: during shelve (2:34:53 PM) mriedem: the port is still logically attached to the instance in the db (2:34:58 PM) mriedem: but there is nothing in the data plane (2:35:17 PM) mlavalle: I don't think it would be a problem. it's just and unbound port, a row in a DB table (2:35:19 PM) openstackgerrit: Merged openstack/networking-bagpipe master: bagpipe-bgp: IPVPN MPLS OVS driver, silently ignore re-removal https://review.openstack.org/559658 (2:35:25 PM) mriedem: mlavalle: ok, cool, thanks But it could be done separately from the unshelve fix to update the device_owner. ** Also affects: nova/queens Importance: Undecided Status: New ** Also affects: nova/ocata Importance: Undecided Status: New ** Also affects: nova/pike Importance: Undecided Status: New -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1759924 Title: Port device owner isn't updated with new host availability zone during unshelve Status in OpenStack Compute (nova): Triaged Status in OpenStack Compute (nova) ocata series: New Status in OpenStack Compute (nova) pike series: New Status in OpenStack Compute (nova) queens series: New Bug description: During an unshelve the host for an instance and therefor the availability zone may change but does not seem to updated in the port's device_owner causing problems with server action add fixed ip for example. In nova/network/neutronv2/api.py _update_port_binding_for_instance should probably update the port's device_owner the same way that _update_ports_for_instance does. +-----------------------+--------------------------------------+ | Field | Value | +-----------------------+--------------------------------------+ | admin_state_up | UP | | allowed_address_pairs | | | binding_host_id | r02c4b15 | | binding_profile | | | binding_vif_details | port_filter='True' | | binding_vif_type | bridge | | binding_vnic_type | normal | | created_at | 2018-03-05T13:25:48Z | | data_plane_status | None | | description | | | device_id | 53f04bf3-eb1f-4c64-a70f-fd16d6c1a5af | | device_owner | compute:zone-r7 | | dns_assignment | | | dns_name | instance-w-volume-shelving-test | | extra_dhcp_opts | | | fixed_ips | | | id | 327b891f-1820-4aa9-bbc3-fe9cc619eac3 | | ip_address | None | | mac_address | fa:16:3e:14:21:d1 | | name | | | network_id | e73b1699-0129-4c12-b722-e6ce52604824 | | option_name | None | | option_value | None | | port_security_enabled | False | | project_id | ecf32b152563403bbde297f58f4637d4 | | qos_policy_id | None | | revision_number | 19 | | security_group_ids | bb25a73a-a62e-4015-9595-16add6b7d3a0 | | status | ACTIVE | | subnet_id | None | | tags | | | trunk_details | None | | updated_at | 2018-03-28T20:03:23Z | +-----------------------+--------------------------------------+ nova show 53f04bf3-eb1f-4c64-a70f-fd16d6c1a5af +--------------------------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | Property | Value | +--------------------------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | OS-DCF:diskConfig | MANUAL | | OS-EXT-AZ:availability_zone | zone-r2 | | OS-EXT-SRV-ATTR:host | r02c4b15 | | OS-EXT-SRV-ATTR:hypervisor_hostname | r02c4b15 To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1759924/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
