Public bug reported: JSON Schema validator.nullable only sets null in the types list. This works except when an enum is set (such as the case with boolean) [0].
The fix is to make validator.nullable() smart enough to add to the ENUM if ENUM is set as well as type. [0] https://github.com/openstack/keystone/blob/56237b709ef901fabfd9e8ba744bbcc4cebf8b9b/keystone/common/validation/__init__.py#L33-L43 ** Affects: keystone Importance: Medium Assignee: Morgan Fainberg (mdrnstm) Status: In Progress ** Affects: keystone/pike Importance: Medium Assignee: Morgan Fainberg (mdrnstm) Status: In Progress ** Affects: keystone/queens Importance: Medium Assignee: Morgan Fainberg (mdrnstm) Status: In Progress ** Affects: keystone/rocky Importance: Medium Assignee: Morgan Fainberg (mdrnstm) Status: In Progress ** Changed in: keystone Status: New => Triaged ** Changed in: keystone Importance: Undecided => Medium ** Changed in: keystone Assignee: (unassigned) => Morgan Fainberg (mdrnstm) ** Also affects: keystone/rocky Importance: Medium Assignee: Morgan Fainberg (mdrnstm) Status: Triaged ** Also affects: keystone/pike Importance: Undecided Status: New ** Also affects: keystone/queens Importance: Undecided Status: New ** Changed in: keystone/queens Status: New => Triaged ** Changed in: keystone/pike Status: New => Triaged ** Changed in: keystone/queens Importance: Undecided => Medium ** Changed in: keystone/pike Importance: Undecided => Medium ** Changed in: keystone/pike Assignee: (unassigned) => Morgan Fainberg (mdrnstm) ** Changed in: keystone/queens Assignee: (unassigned) => Morgan Fainberg (mdrnstm) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Identity (keystone). https://bugs.launchpad.net/bugs/1763824 Title: JSON schema validator.nullable doesn't work with ENUMs Status in OpenStack Identity (keystone): In Progress Status in OpenStack Identity (keystone) pike series: In Progress Status in OpenStack Identity (keystone) queens series: In Progress Status in OpenStack Identity (keystone) rocky series: In Progress Bug description: JSON Schema validator.nullable only sets null in the types list. This works except when an enum is set (such as the case with boolean) [0]. The fix is to make validator.nullable() smart enough to add to the ENUM if ENUM is set as well as type. [0] https://github.com/openstack/keystone/blob/56237b709ef901fabfd9e8ba744bbcc4cebf8b9b/keystone/common/validation/__init__.py#L33-L43 To manage notifications about this bug go to: https://bugs.launchpad.net/keystone/+bug/1763824/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
