Reviewed: https://review.openstack.org/572295 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=11b41d73b48d46b7725bb97d4b85158d8bc2acfb Submitter: Zuul Branch: master
commit 11b41d73b48d46b7725bb97d4b85158d8bc2acfb Author: Slawek Kaplonski <skapl...@redhat.com> Date: Tue Jun 5 10:05:58 2018 +0200 [Fullstack] Wait for SG to be applied by L2 agent In fullstack test_securitygroup there were used simple net_helpers.assert_ping() and assert_not_ping() functions which tries to ping IP address 3 times with some short timeout and test fails if result of ping will not be as expected. Unfortunately sometimes in fullstack tests it might be not enough if test is creating new SG or SG rule or apply SG to port and just after that checks connection because L2 agent don't have enough time to apply all rules on "host". This patch changes it to use block_until_ping() and block_until_no_ping() methods from FakeMachine fixture. It will also check if ping is possible/not possible but will try to check it for 1 minute before fails. Similar change is also done for methods which checks TCP connectivity using netcat helper class. It now uses common_utils.wait_until_true() helper function instead of fail immediatelly. Change-Id: I9e523d803e3c49d5d090ae5b9d36d43ce7311535 Closes-Bug: #1774006 Closes-Bug: #1767829 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1774006 Title: Fullstack security group test fails on _test_using_multiple_security_groups Status in neutron: Fix Released Bug description: Since few days fullstack security groups test is failing quite often in _test_using_multiple_security_groups() Issue is always only with Linuxbridge agent and iptables driver, e.g.: http://logs.openstack.org/37/558037/6/check/neutron-fullstack/85bb570/logs/testr_results.html.gz To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1774006/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp