Public bug reported: Instance group member records used to be in the cell databases but were moved to the API database in Ocata. Previously, when deleting an instance in the cell, we'd also delete it's instance group membership record in the same cell database. Now that instance group membership is modeled in the API DB, we don't cleanup the instance group membership record when an instance is deleted.
The server groups API handles this by filtering out deleted instances which are still listed as group members: https://github.com/openstack/nova/blob/351faa959fc228c726848a68e6ea3f3dadde025e/nova/api/openstack/compute/server_groups.py#L47 However, we could make that more efficient if we didn't have to do those queries / filtering in the first place, by removing the nova_api.instance_group_member records when archiving the database, like we do for instance_mappings request_specs records: https://github.com/openstack/nova/blob/351faa959fc228c726848a68e6ea3f3dadde025e/nova/cmd/manage.py#L553-L561 ** Affects: nova Importance: Low Status: Triaged ** Tags: db performance -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1778804 Title: instance_group_member records not purged from nova_api DB for deleted instances Status in OpenStack Compute (nova): Triaged Bug description: Instance group member records used to be in the cell databases but were moved to the API database in Ocata. Previously, when deleting an instance in the cell, we'd also delete it's instance group membership record in the same cell database. Now that instance group membership is modeled in the API DB, we don't cleanup the instance group membership record when an instance is deleted. The server groups API handles this by filtering out deleted instances which are still listed as group members: https://github.com/openstack/nova/blob/351faa959fc228c726848a68e6ea3f3dadde025e/nova/api/openstack/compute/server_groups.py#L47 However, we could make that more efficient if we didn't have to do those queries / filtering in the first place, by removing the nova_api.instance_group_member records when archiving the database, like we do for instance_mappings request_specs records: https://github.com/openstack/nova/blob/351faa959fc228c726848a68e6ea3f3dadde025e/nova/cmd/manage.py#L553-L561 To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1778804/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
