Reviewed: https://review.openstack.org/557712 Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=0376185fb34a8cba3d8d705e579e08cddfb9316d Submitter: Zuul Branch: master
commit 0376185fb34a8cba3d8d705e579e08cddfb9316d Author: Erno Kuvaja <[email protected]> Date: Wed Mar 28 19:49:48 2018 +0100 Prevent taskflow creation in impossible import This change prevents taskflow creation during image import in cases we know for sure that the image activation won't be successful. The change follows the Glance principles of failing early and tries to provide as meaningful error messages to the end user as possible. Co-authored-by: Abhishek Kekane <[email protected]> Closes-bug: 1758943 Change-Id: Iaee2781d07f4c0afd4f886f0b30b523bd47f1058 ** Changed in: glance Status: New => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to Glance. https://bugs.launchpad.net/bugs/1758943 Title: Image Import creates taskflow for impossible import scenarios Status in Glance: Fix Released Status in Glance queens series: New Status in Glance rocky series: Fix Released Bug description: When the image_import call is made the taskflow is created and responsible handling the rest of the request. It does not do any prechecks if the import conditions are met (like verifying that the image status transition would be possible. This will create lots of tasks that will end up to the database with no apparent reason. We should make at least basic status checks (like if "glance-direct" method was called agains non "uploading" status or "web-download" method used against non "queued" image) before creating the taskflow. To manage notifications about this bug go to: https://bugs.launchpad.net/glance/+bug/1758943/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
