Reviewed: https://review.openstack.org/582976 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ef2949900227e16e0a9494df3adec25d7dae6a14 Submitter: Zuul Branch: master
commit ef2949900227e16e0a9494df3adec25d7dae6a14 Author: Matt Riedemann <[email protected]> Date: Mon Jul 16 11:29:57 2018 -0400 Update HostState.instances during _consume_selected_host Change I4b67ec9dd4ce846a704d0f75ad64c41e693de0fb changed the behavior of the ServerGroupAntiAffinityFilter to rely on HostState.instances being accurate within the same request so that it can compare the number of group members on the same host for filtering. Previously the filter was just checking InstanceGroup.hosts which was updated in the FilterScheduler._consume_selected_host method for each instance processed in a multi-create request. This change updates _consume_selected_host such that if we have an instance group and an instance_uuid (which should always be the case unless conductor is running code older than Pike), then we update HostState.instances with the instance_uuid so the ServerGroupAntiAffinityFilter can properly compare the number of group members against the instances on a given host in a multi-create request. Change-Id: Iacc636fa8a59a9e8670a8d683c10bdbb0dc8237b Closes-Bug: #1781710 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1781710 Title: ServersOnMultiNodesTest.test_create_server_with_scheduler_hint_group_anti_affinity failing with "Servers are on the same host" Status in OpenStack Compute (nova): Fix Released Bug description: Started seeing this recently which looks like a regression: http://logs.openstack.org/44/564444/14/check/neutron-tempest- multinode-full/dba40b9/job-output.txt.gz#_2018-07-13_19_53_15_275866 2018-07-13 19:53:15.275866 | primary | {1} tempest.api.compute.admin.test_servers_on_multinodes.ServersOnMultiNodesTest.test_create_server_with_scheduler_hint_group_anti_affinity [7.164074s] ... FAILED 2018-07-13 19:53:15.275944 | primary | 2018-07-13 19:53:15.276012 | primary | Captured traceback: 2018-07-13 19:53:15.276075 | primary | ~~~~~~~~~~~~~~~~~~~ 2018-07-13 19:53:15.276171 | primary | Traceback (most recent call last): 2018-07-13 19:53:15.276452 | primary | File "tempest/api/compute/admin/test_servers_on_multinodes.py", line 115, in test_create_server_with_scheduler_hint_group_anti_affinity 2018-07-13 19:53:15.276598 | primary | 'Servers are on the same host: %s' % hosts) 2018-07-13 19:53:15.276857 | primary | File "/opt/stack/new/tempest/.tox/tempest/local/lib/python2.7/site-packages/unittest2/case.py", line 845, in assertNotEqual 2018-07-13 19:53:15.276965 | primary | raise self.failureException(msg) 2018-07-13 19:53:15.277830 | primary | AssertionError: u'ubuntu-xenial-rax-dfw-0000714118' == u'ubuntu-xenial-rax-dfw-0000714118' : Servers are on the same host: {u'c166e283-477c-4ecf-9c1c-2dcd731a6d6a': u'ubuntu-xenial-rax-dfw-0000714118', u'6eb63e79-122e-45f9-931f-0750047116d1': u'ubuntu-xenial-rax-dfw-0000714118'} http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22AssertionError%5C%22%20AND%20message%3A%5C%22Servers%20are%20on%20the%20same%20host%3A%5C%22%20AND%20tags%3A%5C%22console%5C%22&from=7d According to logstash, it looks like this started around July 9. These changes merged to nova on July 9 but shouldn't impact this scheduling behavior yet: https://github.com/openstack/nova/commit/57b0bb374963bdbf0aef910feaccb8f536641c41 https://github.com/openstack/nova/commit/afc7650e64753ab7687ae2c4f2714d4bb78a4e5a To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1781710/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
