Reviewed: https://review.openstack.org/589308 Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=254100128d5b9e2d2cdb2c2cd701666f6c343d61 Submitter: Zuul Branch: master
commit 254100128d5b9e2d2cdb2c2cd701666f6c343d61 Author: Lance Bragstad <[email protected]> Date: Mon Aug 6 23:57:00 2018 +0000 Allow for more robust config checking with keystone-manage Keystone was logging a warning saying "no configuration file was found" when one was clearly passed to keystone-manage. This was due to the fact that keystone-manage was really just checking for default configuration file values. This means that users passing a specific configuration file location to keystone-manage would see a warning that wasn't necessarily true since keystone-manage passes sys.argv to oslo.config, which resolves the argument properly. This change enhances the check to make sure keystone-manage isn't dealing with a configuration file passed in from an end-user before emitting the warning. This change also cleans up some of the interactions between keystone.cmd.manage and keystone.cmd.cli to make the variables more clear about their purpose. Change-Id: I6d58d9c499c447ef1cfd6edd4aeb1176130fb6ad Closes-Bug: 1782704 ** Changed in: keystone Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Identity (keystone). https://bugs.launchpad.net/bugs/1782704 Title: keystone "--config-file" cli argument is mis-logged Status in OpenStack Identity (keystone): Fix Released Bug description: Keystone queens version. Move keystone.conf to a custom location and run `keystone-manage --config-file {my custom location}`, the keystone-manage will not find my conf file and `Config file not found, using default configs.` will be prompted. Reproduce: 1. git clone keystone queens 2. pip install -r requirements.txt && pip install --prefix=/openstack 3. Run `keystone-manage --config-file /openstack/etc/keystone/keystone.conf 4. The prompt will be printed. To manage notifications about this bug go to: https://bugs.launchpad.net/keystone/+bug/1782704/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
