Reviewed: https://review.openstack.org/595810 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=375632cbc9019f0e4e887afb5d6e48978f2a1a26 Submitter: Zuul Branch: master
commit 375632cbc9019f0e4e887afb5d6e48978f2a1a26 Author: Balazs Gibizer <[email protected]> Date: Thu Aug 23 16:57:51 2018 +0200 Remove noisy DEBUG log There is a DEBUG log coming from the notification sending code path that tries to populate the notification payload from a nova OVO and encounters an unset / non-lazy loadable field in the source OVO. As there are fields like MonitorMetric.numa_membw_values that are notorious unset in many circumstances but used in the MetricPayload we got excessive DEBUG logging from this code path. This patch removes the offending logging statement as soo far we failed to found cases based on this log where anything else we could do than what the code anyhow does, defaulting the payload field to None. Change-Id: I680e1d9860d839a76e229c4891933872388eb050 Closes-Bug: #1788634 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1788634 Title: Noisy DEBUG log: Defaulting the value of the field 'numa_membw_values' to None in MetricPayload Status in OpenStack Compute (nova): Fix Released Bug description: There are plenty of similar DEBUG log is visible in the nova log: DEBUG nova.notifications.objects.base [None req-af08f64a-756e- 4b43-8357-fd879d3bbbc9 None None] Defaulting the value of the field 'numa_membw_values' to None in MetricPayload due to 'Cannot load 'numa_membw_values' in the base class' {{(pid=145045) populate_schema /opt/stack/nova/nova/notifications/objects/base.py:142}} This logs coming from the notification sending code path [1] that tries to populate the notification payload from a nova OVO and encounters an unset / non-lazy loadable field in the source OVO. As there are fields like MonitorMetric.numa_membw_values that are notorious unset in many circumstances but used in the MetricPayload we got excessive debug logging. [1] https://github.com/openstack/nova/blob/cccba02be8dda0350a215de78b0acde3dbf19716/nova/notifications/objects/base.py#L138 To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1788634/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
