Reviewed: https://review.openstack.org/536351 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e2cc275063658b23ed88824100919a6dfccb760d Submitter: Zuul Branch: master
commit e2cc275063658b23ed88824100919a6dfccb760d Author: int32bit <[email protected]> Date: Mon Jan 22 20:15:21 2018 +0800 Refix disk size during live migration with disk over-commit Currently available disk of targer host is calculated based on local_gb, not available disk(free_disk_gb). This check can be negative if the target host has no free disk. Change-Id: Iec50269ef31dfe090f0cd4db95a37909661bd910 closes-bug: 1744079 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1744079 Title: disk over-commit still not correctly calculated during live migration Status in OpenStack Compute (nova): Fix Released Bug description: Change I8a705114d47384fcd00955d4a4f204072fed57c2 (written by me... sigh) addressed a bug which prevented live migration to a target host with overcommitted disk when made with microversion <2.25. It achieved this, but the fix is still not correct. We now do: if disk_over_commit: disk_available_gb = dst_compute_info['local_gb'] Unfortunately local_gb is *total* disk, not available disk. We actually want free_disk_gb. Fun fact: due to the way we calculate this for filesystems, without taking into account reserved space, this can also be negative. The test we're currently running is: could we fit this guest's allocated disks on the target if the target disk was empty. This is at least better than it was before, as we don't spuriously fail early. In fact, we're effectively disabling a test which is disabled for microversion >=2.25 anyway. IOW we should fix it, but it's probably not a high priority. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1744079/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
