Reviewed: https://review.openstack.org/596683 Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=67435147ec4fc9762743c9474a17999a500fda07 Submitter: Zuul Branch: master
commit 67435147ec4fc9762743c9474a17999a500fda07 Author: Vishakha Agarwal <[email protected]> Date: Mon Aug 27 15:39:23 2018 +0530 Incorrect use of translation _() Keystone uses translated strings both in logging an exceptions. This is incorrect. All strings that are passed to logging should remain un-translated. This patch addresses above issue. Change-Id: Idf4f0bc1bd63eb8dc6dc61d8a49a9e2a93320474 Closes-Bug: #1777671 ** Changed in: keystone Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Identity (keystone). https://bugs.launchpad.net/bugs/1777671 Title: Incorrect use of translation _() Status in OpenStack Identity (keystone): Fix Released Bug description: Keystone uses translated strings both in logging an exceptions. This is incorrect. All strings that are passed to logging should remain un-translated. The solution is to duplicate the string and pass the untranslated (not wrapped with `_()`) to the logger while passing the translated `_()` wrapped string to the exception. Relevant Discussion: http://eavesdrop.openstack.org/irclogs /%23openstack-oslo/%23openstack- oslo.2018-06-18.log.html#t2018-06-18T22:03:19 To manage notifications about this bug go to: https://bugs.launchpad.net/keystone/+bug/1777671/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
