Reviewed: https://review.openstack.org/605442 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=6c2225bab8b007023e031d829bc72e8e50e6f1df Submitter: Zuul Branch: master
commit 6c2225bab8b007023e031d829bc72e8e50e6f1df Author: Edward Hope-Morley <edward.hope-mor...@canonical.com> Date: Wed Sep 26 15:36:03 2018 +0100 Add enabled check in Backups panel If enable_backup is False in OPENSTACK_CINDER_FEATURES then we should not display the backups panel. Change-Id: I276eebf0f11406bf354f5d8bbecef7b244d6d340 Closes-Bug: #1778771 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1778771 Title: Backups panel is visible even if enable_backup is False Status in OpenStack openstack-dashboard charm: In Progress Status in OpenStack Dashboard (Horizon): Fix Released Bug description: Hi, Volumes - Backup panel is visible even if OPENSTACK_CINDER_FEATURES = {'enable_backup': False} in local_settings.py Meanwhile setting enable_backup to false removes an option to create backup of a volume in the volume drop-down options. But panel with backups itself stays visible for both admins and users. As a work-around I use the following customization script: import horizon from django.conf import settings if not getattr(settings, 'OPENSTACK_CINDER_FEATURES', {}).get('enable_backup', False): project = horizon.get_dashboard("project") backup = project.get_panel("backups") project.unregister(backup.__class__) And for permanent fix I see the following decision. In openstack_dashboard/dashboards/project/backups/panel.py make the following changes: ... +L16: from django.conf import settings ... +L21: if not getattr(settings, 'OPENSTACK_CINDER_FEATURES', {}).get('enable_backup', False): +L22: return False ... To manage notifications about this bug go to: https://bugs.launchpad.net/charm-openstack-dashboard/+bug/1778771/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp