Reviewed: https://review.openstack.org/608777 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a99722bb854d2ba99c3abc2d2738ba281148fde4 Submitter: Zuul Branch: master
commit a99722bb854d2ba99c3abc2d2738ba281148fde4 Author: Matt Riedemann <[email protected]> Date: Mon Oct 8 17:33:49 2018 -0400 Properly track local root disk usage during moves Change I0839470c4bcfb16590a0d87b306d683b059bf8a9 fixed root disk usage tracking for volume-backed instances when performing an instance_claim which happens during the initial server create and unshelve. However, root disk reporting is still wrong for volume-backed instances during move claims (resize and evacuate) because a move claim calls _update_usage_from_migration which passes a Flavor object to ResourceTracker._get_usage_dict() and that method didn't have "is_bfv" logic in that scenario. This fixes the bug by always passing the instance object to the _get_usage_dict() method so we can determine if it's volume-backed and if so report the root_gb usage as 0. The related functional regression test is updated appropriately to show the bug is fixed for volume-backed instances. Change-Id: Ia19264ae7c88bb03ed3118795d4011ceb62ef92c Closes-Bug: #1796737 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1796737 Title: resize: hypervisor local_gb_used still reports usage even with volume- backed instances after fix for bug 1469179 Status in OpenStack Compute (nova): Fix Released Status in OpenStack Compute (nova) rocky series: In Progress Bug description: This is a follow up to bug 1782393 which handled reporting 0 local_gb_used during an instance claim in the resource tracker but we still have the same issue with resize claims ignoring volume-backed instances. This is the instance_claim fix: https://review.openstack.org/#/c/584204/ The problem is here during a resize: https://github.com/openstack/nova/blob/f63fd14975cda83d24121b010cbedfc3a7e5ff1f/nova/compute/resource_tracker.py#L1027 That passes the flavor object to the _get_usage_dict method which doesn't handle the is_bfv case: https://github.com/openstack/nova/blob/f63fd14975cda83d24121b010cbedfc3a7e5ff1f/nova/compute/resource_tracker.py#L1466 To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1796737/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
