Reviewed: https://review.openstack.org/621346 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1e8c2c0dcb3ff9225407b890a6c99658b35764bc Submitter: Zuul Branch: master
commit 1e8c2c0dcb3ff9225407b890a6c99658b35764bc Author: Michael Still <[email protected]> Date: Sat Dec 1 21:35:01 2018 +1100 Fix sloppy initialization of the new disk ops semaphore. Some tests weren't calling init_host, so the semaphore was None. This caused the smoke to come out of nova's tests in ways that would be less confusing if they'd failed during the testing of the implementing patch. Instead, set the semaphore to being unbounded, and then override that later if the user has in fact specified a limit. This relies on init_host being called very early, but that should be true already. Change-Id: If144be253f78b14cef60200a46aefc02c0e19ced Closes-Bug: #1806123 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1806123 Title: i/o concurrency semaphore test changes are racy Status in OpenStack Compute (nova): Fix Released Bug description: Seen here: http://logs.openstack.org/22/606122/7/check/openstack-tox- py27/d70a4d5/testr_results.html.gz ft1.7: nova.tests.unit.virt.libvirt.test_driver.LibvirtSnapshotTests.test_raw_with_rbd_clone_failure_does_cold_snapshot_StringException: pythonlogging:'': {{{ 2018-11-30 16:46:13,885 WARNING [os_brick.initiator.connectors.remotefs] Connection details not present. RemoteFsClient may not initialize properly. 2018-11-30 16:46:13,888 INFO [nova.virt.libvirt.driver] Beginning live snapshot process 2018-11-30 16:46:13,889 WARNING [nova.virt.libvirt.driver] Performing standard snapshot because direct snapshot failed: Cannot determine the parent storage pool for 155d900f-4e14-4e4c-a73d-069cbf4541e6; cannot determine where to store images 2018-11-30 16:46:13,889 INFO [nova.virt.libvirt.driver] Snapshot extracted, beginning image upload }}} Traceback (most recent call last): File "/home/zuul/src/git.openstack.org/openstack/nova/.tox/py27/local/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched return func(*args, **keywargs) File "nova/tests/unit/virt/libvirt/test_driver.py", line 22336, in test_raw_with_rbd_clone_failure_does_cold_snapshot recv_meta['id'], self.mock_update_task_state) File "nova/virt/libvirt/driver.py", line 1971, in snapshot with compute_utils.disk_ops_semaphore: AttributeError: __exit__ Introduced with this change: https://review.openstack.org/#/c/609180/ http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22with%20compute_utils.disk_ops_semaphore%3A%5C%22%20AND%20tags%3A%5C%22console%5C%22&from=7d 22 hits, all failures, check and gate. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1806123/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
