Reviewed: https://review.openstack.org/626401 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=4bb78e8c215d24cd2fc9168e7bfbb47ceb89de3e Submitter: Zuul Branch: master
commit 4bb78e8c215d24cd2fc9168e7bfbb47ceb89de3e Author: Brian Haley <[email protected]> Date: Wed Dec 19 16:55:47 2018 -0500 Fix l3-agent usage of L3AgentExtension class The L3AgentExtension class delete_router() method expects a dict as it's 'data' argument, but the l3-agent code that deletes a router was passing just the router ID. Change to correctly pass a router dictionary if one exists. Change-Id: I112d1f8dce9defddfbd8fbfa75bf538e308e1561 Closes-bug: #1809134 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1809134 Title: TypeError in QoS gateway_ip code in l3-agent logs Status in neutron: Fix Released Bug description: Seeing this traceback in the l3-agent logs in the failing neutron- tempest-plugin-dvr-multinode-scenario job. For example, http://logs.openstack.org/23/622623/3/check/neutron-tempest-plugin-dvr-multinode-scenario/604b3c0/controller/logs/screen-q-l3.txt.gz?level=WARNING neutron-l3-agent[13439]: ERROR neutron.agent.l3.agent [-] Error while deleting router da35128f-c2e4-4bc5-a409-a07f60970be1: TypeError: string indices must be integers neutron-l3-agent[13439]: ERROR neutron.agent.l3.agent Traceback (most recent call last): neutron-l3-agent[13439]: ERROR neutron.agent.l3.agent File "/opt/stack/neutron/neutron/agent/l3/agent.py", line 398, in _safe_router_removed neutron-l3-agent[13439]: ERROR neutron.agent.l3.agent self.l3_ext_manager.delete_router(self.context, router_id) neutron-l3-agent[13439]: ERROR neutron.agent.l3.agent File "/opt/stack/neutron/neutron/agent/l3/l3_agent_extensions_manager.py", line 66, in delete_router neutron-l3-agent[13439]: ERROR neutron.agent.l3.agent extension.obj.delete_router(context, data) neutron-l3-agent[13439]: ERROR neutron.agent.l3.agent File "/opt/stack/neutron/neutron/agent/l3/extensions/qos/gateway_ip.py", line 99, in delete_router neutron-l3-agent[13439]: ERROR neutron.agent.l3.agent self.gateway_ip_qos_map.clean_by_resource(data['id']) neutron-l3-agent[13439]: ERROR neutron.agent.l3.agent TypeError: string indices must be integers This could be one of the reasons the job is failing. To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1809134/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
