Reviewed: https://review.openstack.org/635185 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ccec9ba82de7c9525981a34bb126e9ca98042d04 Submitter: Zuul Branch: master
commit ccec9ba82de7c9525981a34bb126e9ca98042d04 Author: Dan Smith <[email protected]> Date: Wed Feb 6 06:54:00 2019 -0800 Fix InstanceMapping to always default queued_for_delete=False This object has a default=False setting for queued_for_delete, but never actually sets that value. All newly created records should have a non-NULL value for this field, and we have a migration to fix them, so this change explicitly forces that =False, unless the object is being created with a value set. Closes-Bug: #1814913 Change-Id: I99c5cc24c7e9bf5e2e72ffc868990b87b0e8e3f8 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1814913 Title: A new instance_mapping record will have queued_for_delete set to NULL Status in OpenStack Compute (nova): Fix Released Status in OpenStack Compute (nova) rocky series: Confirmed Bug description: After this change: https://review.openstack.org/#/c/584504, where we changed the default value of queued_for_delete column from False to NULL in the sqla code for the instance_mappings object (to do the data migration for queued_for_delete), we forgot to set the default value as False upon creation of the new instance_mappings in the create() method. Hence new instance_mappings always ended up with NULL values in the db meaning the data migration "populate_queued_for_delete" would never finish. So in the InstanceMapping.create() function queued_for_delete should always be set to False() explicitly so that new mappings get False as the default value. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1814913/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
