Reviewed: https://review.openstack.org/641509 Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=d5c0daa8b7cbf752b02b6585225035886295c887 Submitter: Zuul Branch: master
commit d5c0daa8b7cbf752b02b6585225035886295c887 Author: Tim Burke <[email protected]> Date: Wed Mar 6 14:43:45 2019 -0800 py3: Fix return type on CooperativeReader.read This should always be bytes; previously there was a path that returned an empty native string. Change-Id: I1cb4997cd3e766f9a7aea41ebe41a73971496bc3 Closes-Bug: #1818919 ** Changed in: glance Status: Triaged => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to Glance. https://bugs.launchpad.net/bugs/1818919 Title: CooperativeReader not py3-ready Status in Glance: Fix Released Status in Glance queens series: New Status in Glance rocky series: New Status in Glance stein series: Fix Released Bug description: Tim Burke noticed this in IRC today: https://github.com/openstack/glance/blob/17.0.0/glance/common/utils.py#L231 Should be returning b'' since we're supposed to be returning bytes. Apparently our unit tests could use some beefing up, because they're not breaking under py3. To manage notifications about this bug go to: https://bugs.launchpad.net/glance/+bug/1818919/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
